-
Notifications
You must be signed in to change notification settings - Fork 24
feat(kms): Add KMS under beta #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@rubenhoenle are there any updates on the PR? I would love to use it in my pipeline. |
|
||
var ( | ||
testProjectId = uuid.NewString() | ||
testRegion = "eu01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testRegion = "eu01" | |
const testRegion = "eu01" |
Well, the region is required for every API endpoint, it will just be "eu01" for now all the time. But please use the regular multi-region implementation like we do for all the other commands. So we're ready for the future :)
|
Thank you for taking the time to review my code. I have implemented your suggestions to the best of my abilities. However, I have not been able to switch from the Will this be a dealbreaker? Or can we move ahead with the merge and update kms later? (Isn't it in beta for a reason?) |
The Will have to look through the rest of your PR another time, hopefully tomorrow, sorry. |
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
@rubenhoenle let's not let this merge become stale. What do you think, can we get it to the needed state? |
@rubenhoenle anything I can do for your? |
Description
relates to #934
KMS has been added to the CLI. Now the following commands exist:
Checklist
make fmt
make generate-docs
(will be checked by CI)make test
(will be checked by CI)make lint
(will be checked by CI)Important Decisions
The CLI implementation of KMS reflects the state of the API, which includes some seemingly unfinished decisions.
Hope this actually helps and huge thanks to whomever tries to tackle this monster merge.