-
Notifications
You must be signed in to change notification settings - Fork 705
Chore/aac rename clarity error #6505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/aac rename clarity error #6505
Conversation
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we just need to make a decision about the errors with multiple parameters
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A conflict need to be addressed
…rk/stacks-core into chore/aac-rename-clarity-error
LGTM; happy to re-approve once merge conflicts are fixed |
…rk/stacks-core into chore/aac-rename-clarity-error
…rk/stacks-core into chore/aac-rename-clarity-error
Replaced by #6497 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## aac-client-breaking #6505 +/- ##
=======================================================
+ Coverage 79.88% 80.57% +0.68%
=======================================================
Files 565 565
Lines 346594 346602 +8
=======================================================
+ Hits 276882 279258 +2376
+ Misses 69712 67344 -2368
... and 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #6454