Skip to content

Conversation

jferrant
Copy link
Contributor

@jferrant jferrant commented Sep 16, 2025

Closes #6461

Replaces #6505
Replaces #6509
Replaces #6500

@jferrant jferrant requested review from a team as code owners September 16, 2025 21:53
@jferrant jferrant added aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change labels Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 63.94810% with 389 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.55%. Comparing base (927747c) to head (a9d4c77).
⚠️ Report is 44 commits behind head on aac-client-breaking.

Files with missing lines Patch % Lines
clarity/src/vm/ast/parser/v2/mod.rs 9.85% 64 Missing ⚠️
clarity-types/src/errors/ast.rs 38.46% 40 Missing ⚠️
clarity/src/vm/database/clarity_db.rs 33.33% 40 Missing ⚠️
clarity/src/vm/database/structures.rs 53.48% 40 Missing ⚠️
clarity/src/vm/ast/parser/v1.rs 48.27% 30 Missing ⚠️
stackslib/src/clarity_vm/database/marf.rs 36.84% 24 Missing ⚠️
clarity/src/vm/clarity.rs 50.00% 20 Missing ⚠️
clarity/src/vm/contexts.rs 69.23% 12 Missing ⚠️
clarity/src/vm/database/key_value_wrapper.rs 29.41% 12 Missing ⚠️
stackslib/src/clarity_vm/database/ephemeral.rs 9.09% 10 Missing ⚠️
... and 34 more
Additional details and impacted files
@@                   Coverage Diff                   @@
##           aac-client-breaking    #6497      +/-   ##
=======================================================
- Coverage                79.88%   79.55%   -0.33%     
=======================================================
  Files                      565      565              
  Lines                   346594   346632      +38     
=======================================================
- Hits                    276882   275774    -1108     
- Misses                   69712    70858    +1146     
Files with missing lines Coverage Δ
clarity-types/src/lib.rs 100.00% <ø> (ø)
clarity-types/src/representations.rs 85.49% <ø> (ø)
clarity-types/src/tests/representations.rs 75.00% <ø> (ø)
clarity-types/src/tests/types/mod.rs 96.86% <100.00%> (ø)
clarity-types/src/tests/types/serialization.rs 98.31% <100.00%> (ø)
clarity-types/src/types/serialization.rs 92.05% <100.00%> (ø)
clarity/src/vm/analysis/trait_checker/tests.rs 85.42% <ø> (ø)
...ty/src/vm/analysis/type_checker/v2_05/tests/mod.rs 99.89% <100.00%> (ø)
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 99.84% <ø> (ø)
clarity/src/vm/ast/definition_sorter/mod.rs 95.27% <100.00%> (ø)
... and 85 more

... and 72 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927747c...a9d4c77. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant force-pushed the chore/aac-rename-parse-errors branch from 708dfee to 6d4560f Compare September 17, 2025 17:32
@jferrant jferrant requested a review from Jiloc September 17, 2025 17:33
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

just added small remarks to possibly improve the documentation

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant dismissed stale reviews from jcnelson, fdefelici, and Jiloc via 9065c01 September 23, 2025 01:35
@Jiloc Jiloc added this pull request to the merge queue Sep 25, 2025
Merged via the queue into stacks-network:aac-client-breaking with commit fb129a4 Sep 25, 2025
297 of 302 checks passed
Copy link

github-actions bot commented Oct 3, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Oct 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change locked
Projects
None yet
4 participants