Skip to content

Conversation

jferrant
Copy link
Contributor

Closes #6456

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested review from a team as code owners September 17, 2025 23:28
@jferrant jferrant added aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change labels Sep 17, 2025
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested a review from Jiloc September 18, 2025 16:12
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Jiloc
Jiloc previously approved these changes Sep 19, 2025
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

A Conflict need to be addressed

jcnelson
jcnelson previously approved these changes Sep 22, 2025
@jcnelson
Copy link
Member

Just need to address conflicts and I'll re-approve

fdefelici
fdefelici previously approved these changes Sep 23, 2025
@jferrant
Copy link
Contributor Author

Replaced by #6497

@jferrant jferrant closed this Sep 24, 2025
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 67.18750% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.66%. Comparing base (927747c) to head (aa1d5aa).
⚠️ Report is 8 commits behind head on aac-client-breaking.

Files with missing lines Patch % Lines
clarity/src/vm/costs/costs_1.rs 3.84% 25 Missing ⚠️
clarity/src/vm/database/clarity_db.rs 55.55% 4 Missing ⚠️
pox-locking/src/pox_2.rs 0.00% 4 Missing ⚠️
pox-locking/src/pox_3.rs 0.00% 4 Missing ⚠️
pox-locking/src/pox_4.rs 0.00% 4 Missing ⚠️
clarity-types/src/types/mod.rs 70.00% 3 Missing ⚠️
clarity/src/vm/contexts.rs 50.00% 3 Missing ⚠️
stackslib/src/clarity_vm/database/marf.rs 25.00% 3 Missing ⚠️
clarity/src/vm/costs/costs_3.rs 0.00% 2 Missing ⚠️
clarity/src/vm/functions/sequences.rs 33.33% 2 Missing ⚠️
... and 8 more

❌ Your project status has failed because the head coverage (67.66%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           aac-client-breaking    #6509       +/-   ##
========================================================
- Coverage                79.88%   67.66%   -12.23%     
========================================================
  Files                      565      565               
  Lines                   346594   346574       -20     
========================================================
- Hits                    276882   234513    -42369     
- Misses                   69712   112061    +42349     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 56.79% <100.00%> (-18.52%) ⬇️
clarity-types/src/representations.rs 84.25% <ø> (-1.24%) ⬇️
clarity-types/src/tests/representations.rs 75.00% <ø> (ø)
clarity-types/src/tests/types/mod.rs 70.03% <100.00%> (-26.83%) ⬇️
clarity/src/vm/costs/cost_functions.rs 100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_2.rs 100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_2_testnet.rs 100.00% <100.00%> (ø)
clarity/src/vm/costs/mod.rs 78.87% <ø> (-3.79%) ⬇️
clarity/src/vm/database/structures.rs 79.76% <100.00%> (+0.10%) ⬆️
clarity/src/vm/functions/arithmetic.rs 89.18% <100.00%> (-1.61%) ⬇️
... and 32 more

... and 326 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927747c...aa1d5aa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Oct 2, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Oct 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename and document clarity::vm::errors::RuntimeErrorType to RuntimeError
4 participants