Skip to content

Conversation

jferrant
Copy link
Contributor

No description provided.

jferrant and others added 30 commits September 11, 2025 11:40
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…t_static_problematic_tests

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…o rejectable()

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
… into chore/merge-develop-to-aac-client-breaking
… into chore/merge-develop-to-aac-client-breaking
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested review from Jiloc and fdefelici September 25, 2025 16:47
@jferrant jferrant requested review from a team as code owners September 25, 2025 16:47
@jferrant jferrant added the aac Avoiding Accidental Consensus label Sep 25, 2025
@jferrant jferrant requested a review from kantai September 25, 2025 17:10
@Jiloc Jiloc added this pull request to the merge queue Sep 26, 2025
Merged via the queue into stacks-network:aac-client-breaking with commit 962e7dd Sep 26, 2025
296 of 301 checks passed
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 73.75887% with 333 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.01%. Comparing base (fb129a4) to head (f1e1291).
⚠️ Report is 77 commits behind head on aac-client-breaking.

Files with missing lines Patch % Lines
contrib/stacks-inspect/src/main.rs 0.00% 99 Missing ⚠️
stackslib/src/clarity_cli.rs 80.76% 50 Missing ⚠️
stackslib/src/net/api/blockreplay.rs 83.84% 42 Missing ⚠️
contrib/stacks-inspect/src/lib.rs 0.00% 36 Missing ⚠️
contrib/stacks-cli/src/main.rs 61.11% 21 Missing ⚠️
stackslib/src/chainstate/burn/db/sortdb.rs 80.64% 12 Missing ⚠️
stackslib/src/chainstate/stacks/miner.rs 70.27% 11 Missing ⚠️
pox-locking/src/events.rs 40.00% 9 Missing ⚠️
stackslib/src/net/relay.rs 74.28% 9 Missing ⚠️
stackslib/src/chainstate/stacks/db/transactions.rs 94.40% 7 Missing ⚠️
... and 12 more

❌ Your project status has failed because the head coverage (75.01%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (fb129a4) and HEAD (f1e1291). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (fb129a4) HEAD (f1e1291)
142 133
Additional details and impacted files
@@                   Coverage Diff                   @@
##           aac-client-breaking    #6538      +/-   ##
=======================================================
- Coverage                80.18%   75.01%   -5.17%     
=======================================================
  Files                      565      566       +1     
  Lines                   346632   345526    -1106     
=======================================================
- Hits                    277931   259183   -18748     
- Misses                   68701    86343   +17642     
Files with missing lines Coverage Δ
clarity-types/src/errors/ast.rs 42.25% <100.00%> (-10.23%) ⬇️
clarity/src/vm/analysis/mod.rs 94.79% <100.00%> (-0.31%) ⬇️
clarity/src/vm/clarity.rs 83.11% <100.00%> (-0.15%) ⬇️
clarity/src/vm/contexts.rs 85.82% <100.00%> (-5.86%) ⬇️
clarity/src/vm/database/clarity_db.rs 78.30% <ø> (+0.02%) ⬆️
clarity/src/vm/docs/contracts.rs 94.26% <100.00%> (-0.05%) ⬇️
clarity/src/vm/docs/mod.rs 87.90% <100.00%> (-2.34%) ⬇️
clarity/src/vm/test_util/mod.rs 56.74% <100.00%> (-0.59%) ⬇️
clarity/src/vm/tests/assets.rs 100.00% <ø> (ø)
clarity/src/vm/tests/contracts.rs 100.00% <ø> (ø)
... and 59 more

... and 222 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb129a4...f1e1291. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Oct 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Oct 4, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aac Avoiding Accidental Consensus locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants