You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Minor Changes
Binding APPROVE now rechecks live open threads before posting: unresolved live threads the local store doesn't know about refuse APPROVE with a typed error (triage or --force); an unreachable lookup degrades to COMMENT with the reason stated instead of approving blind. COMMENT, dry-run, and local flows make no new network calls.
Attribution v2: the footer default is now a linked, leveled, logo-bearing line — a product-linked 18px logo (defaulting to the tracked apps/docs/public/logo.svg raw asset) plus Reviewed with [**Verdict {version}**](https://stainless-code.com/verdict) with the version inline space-separated, followed by the receipt fields. publish.attribution migrates from the day-old P1 bool to an off/product/full enum (file bools refuse with the mapping named: "off" for false, "product" for true; full appends by [Stainless Code](https://stainless-code.com)). New publish.logo (default true) and publish.logo_url knobs (empty reads text-only, never a broken image); a <!-- verdict-footer --> machine divider separates content from footer with strip-and-replace re-rendering; attribution_text gains the {version}/{tier}/{product_url} inventory with unknown placeholders refused.
Opt-in behavioral diagram: agent-drawn mermaid under a ported contract (prompts/diagrams.md with the 7-type selection map, honesty rule, and copy-exact skeletons), gated by a new publish.diagrams namespace (behavioral default off, structural default on for the P3 topology half, expanded default collapsed), grammar-level warn-and-drop validation that never fails a review, and --diagram-behavioral/--diagram-structural/--diagram-expanded flag pairs.
Bounded verify-gated fix loops: new fix verb runs one pass per invocation over local bundles (top open inline sig or --sig), printing finding + full kb.txt context with patch → verification.json → record → re-run instructions. Hard-coded ceilings (max 3 passes per sig in .review/<bundle>/fix.json, scope-escape on out-of-anchor worktree touches), start gates (conflicted tree, closed bundle), terminal completion summary, local-only in v1.
Self-grading probe: calibrate --probe grades recorded findings against triage dispositions as the script-owned baseline, and merges agent judgments (--judge/--judge-file, validated, atomic, sticky) that may diverge — the agreement/dissent rate over doubly-judged rows is the instrument reading. Additive grade file only; findings, joins, and calibration rows untouched.
Anchors validate against the fetch-time snapshot: fetch pins the commentable set and post/record/adopt reuse it (rebuilding only if missing, with a warning); dropped anchors ship as named body notes with reasons instead of failing or misplacing silently. Mid-run pushes read as drift context, not a moving validation target.
Structured local knowledge base: learn verb (append/list/retire/restore scoped rules with provenance, rigor, hit counters), kb.txt recall onto relevant diffs as context-never-orders, flip-time credit with false-hit-rate auto-retirement, and per-credit audit rows.
Knowledge base: re-posting a finding without kb keeps the prior cite while explicit "kb": [] clears it (uncite); every .review/kb-joins.jsonl audit row now also carries bundle and review_id.
Overlap audit: trend --overlap joins recall manifests × findings cites × the joins ledger into recall precision, recall coverage of cites, and the cited-outcome split, with joins corroboration and calibrate eligibility. Pure read, no network; missing manifests read as unmeasured, never zero.
Change overview: report --output renders a script-computed collapsed file table plus a flowchart TD
change-topology diagram on large diffs (more than 8 files or 24KB, --overview/--no-overview override),
with stable F-row ids, deterministic relations only, and a new publish.overview knob.
Permalink-first evidence: findings reference GitHub blob links pinned to the reviewed SHA (reference-style, path:line locators with definitions), with quotes over three lines kept inside collapsed detail blocks
only. Non-GitHub bundles degrade to plain path:line text. Link validation warns and keeps, never failing
a review over garnish.
Debug legibility: fetch/fetch-local --show-prompts dumps the exact assembled prompt (system + mode + recall + coverage manifest) without running an agent; report --output bodies lead with confidence plus safety and list up to seven checked files on clean reviews, with full reasoning staying in the machine envelope.
Publish footer: posted bodies and report --output end with a merged receipt block (tool version, tier, cost or unrecorded, files reviewed, review link when known) including a factual one-sentence attribution, plus a deterministic confidence-basis line (rigor counts, cited rules, verified fixes). New publish settings namespace (footer/attribution/attribution_text/copyright) with flags beating file beating env; agent Basis lines validate warn-and-keep, never failing a review.
Recall manifest: the recall step emits kb-recall.json (recalled rule ids in rank order with scores) beside kb.txt, rendered from the same single sort. The human note is byte-identical, silence on clean is preserved, and all readers tolerate a missing manifest.
Report gate answers "is HEAD reviewed?": new opt-in --completeness flag on report (alone or with --check <tier>) compares the fetched HEAD against the completed-post record, failing closed with a typed error naming the re-fetch command. Without the flag, output and exits are unchanged.
Onboarding pair: review.sh init scaffolds the standard local control files (budget, panel, KB policy, KB starter) with chill/standard/strict presets and runs check-tree validation, offline with preview-then-confirm; an XDG-homed presentation-only settings file (output/layout/color, schema-hinted, credentials refused) ends env sprawl with flags winning over file over env and byte-identical behavior when absent.
Operator-owned template overrides: per-block fragments under .review/overrides/ (preamble, footer
order, walkthrough threshold, attribution) guarded by an enumerated locked-invariant list (marker line,
findings structure, guard satisfiability, metadata presence, divider shape), validated at check-tree time
and revalidated at post time with typed refusals. check-tree --json emits the standard envelope on all
paths.
Exactly one terminal write, enforced: post refuses a second completed post on the same reviewed SHA with a typed error (--force overrides, new commits re-arm automatically). Dry runs, attempts, and failures never arm the guard. The existing exact-payload replay guard stays as the fine layer underneath.
Copy-based skill installer: new review.sh install verb detects the de-facto agent skill dirs (.agents/skills, .claude/skills, .codex/skills at the repo root and $HOME), previews the copy plan for the tool-owned verdict/ payload (SKILL.md + prompts/), and applies only on explicit confirm (same preview-then-confirm idiom as init, typed needs-confirm). Only installer-owned verdict/ dirs (with a .verdict-managed receipt) are ever written — foreign skills and unowned dirs stay byte-identical; re-runs are idempotent and receipt/tool version skew warns instead of failing. Offline, shellcheck-clean, operator docs updated.
Patch Changes
Bird's-eye review follow-ups: indented fenced blocks (up to 3 columns) now validate, single-line
fences never open an end-of-body swallow, drop-notes insert before a carried footer divider so
strip-replace preserves them, the doc wrapper is a parseable multi-line block, and the manual
documents the full v1 placeholder inventory.
Pre-commit runs shellcheck -S warning over staged shell files (missing binary skips with
a notice, same degrade-gracefully idiom as the formatter check), and the CI lint job covers
every tracked *.sh instead of three hardcoded paths. Pinned by a hermetic hook eval
(violate fails, clean passes, missing binary skips).