Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin/print and Extremely Small Numbers #113

Merged
merged 2 commits into from
Jun 11, 2013

Conversation

betanalpha
Copy link
Contributor

Parse CSV by hand and convert string values to doubles using boost::lexical cast instead of std::stringstream::operator>> which fails on numbers whose exponent has more than two digits.

@stan-buildbot
Copy link
Contributor

Can one of the admins verify this patch?

@mbrubake
Copy link
Member

Looks good to me. I don't know how to make Jenkins test this though but assuming their good it looks good.
@syclik?

@syclik
Copy link
Member

syclik commented Jun 10, 2013

Jenkins, ok to test.

@stan-buildbot
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Github%20Pull%20Requests/60/

syclik added a commit that referenced this pull request Jun 11, 2013
Fix bin/print and Extremely Small Numbers
@syclik syclik merged commit 02b9e3b into develop Jun 11, 2013
@syclik syclik deleted the feature/fix_print_and_sci_note branch June 11, 2013 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants