[6.x] Container queries for publish fields #12644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix their width when they're in a narrow stack
… nav item in cp/navigation/something)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12108.
Publish fields now query the
data-ui-panelcontainer rather than a viewport media query.The Problem
When publish fields were in a narrow stack—such as when adding a nav item—grid gaps were calculated as wide because the viewport was wide.
By adding a container to the
data-ui-panelwe can query the width of that instead.While I was here, I've also increased the y-value of the gap on smaller containers. I think we should mostly reduce the x value when there is a smaller space.