[4.x] Add validation replacements to replicator and grid field types #10064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianbrinkmann
force-pushed
the
add-validator-replacements-to-replicator-and-grid
branch
from
ebd9f9c
to
5b8a4e2
Compare
duncanmcclean
changed the title
|
We're no longer accepting fixes to |
|
If this is still important for you, please feel free to update this PR to target 5.x and we can reopen. Or, open a fresh PR. Up to you. Thanks! |
|
Will update it next week |
|
I created a new PR, because it seems I cannot re-target the existing one #10255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it’s not possible to use the validation replacements (for example,
validation_rule_handle:{id}) in fields that are part of replicator or grid fields, because the validator instance that is used for the »top-level« fields isn’t the same that’s used for the fields inside the replicator/grid (at least I think that’s the reason).This PR changes that and adds the replacements for replicator and grid fields, if the parent is an Entry.
Closes #10065