[5.x] Ability to opt out of async slug behavior, and opt out in field settings #10075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async behavior is more correct as it uses the server-side slug logic, but it's slower because it makes server requests.
This PR adds the ability to opt out of it when using the
<slugify>
component by adding anasync="false"
prop, or theslug
fieldtype by adding anasync: false
option.While I wasn't able to reproduce the completely incorrect slug behavior as described in #9959, I'm guessing that people were able to somehow trigger an issue in the additional debouncing within the Slug JS class itself. Since the async is opted out of in field settings now, it'll be back to how it performed in v4. The only delay is now the standard debouncing when you type into the title field.
It's possible the issue will reappear in other places that still use the async slugging, like the entry publish form. We'll address it then.
Closes #9959