Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Ability to opt out of async slug behavior, and opt out in field settings #10075

Merged
merged 2 commits into from
May 14, 2024

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented May 14, 2024

The async behavior is more correct as it uses the server-side slug logic, but it's slower because it makes server requests.

This PR adds the ability to opt out of it when using the <slugify> component by adding an async="false" prop, or the slug fieldtype by adding an async: false option.

While I wasn't able to reproduce the completely incorrect slug behavior as described in #9959, I'm guessing that people were able to somehow trigger an issue in the additional debouncing within the Slug JS class itself. Since the async is opted out of in field settings now, it'll be back to how it performed in v4. The only delay is now the standard debouncing when you type into the title field.

It's possible the issue will reappear in other places that still use the async slugging, like the entry publish form. We'll address it then.

Closes #9959

@jasonvarga jasonvarga merged commit d140dd4 into 5.x May 14, 2024
33 checks passed
@jasonvarga jasonvarga deleted the slugs branch May 14, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fieldset builder: field titles not updating
1 participant