Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Taggable fieldtype tweaks #10121

Merged
merged 2 commits into from
May 20, 2024
Merged

[5.x] Taggable fieldtype tweaks #10121

merged 2 commits into from
May 20, 2024

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented May 20, 2024

While reviewing #9933 I noticed a couple of little things that would be nice to address.

First, setting to close on select. This mimics how the relationship fieldtype works when in taggable mode.
The issue is that when you enter a tag, the dropdown doesn't close, so you can't see the values until you manually close it by hitting escape or clicking away.

Before:
CleanShot 2024-05-20 at 16 47 16

After:
CleanShot 2024-05-20 at 16 51 04

The other thing is that the dropdown is visible even if there are no options. It's not really useful. You can see this in the previous gif. Now you'll only see the dropdown if there are options.

No options:
CleanShot 2024-05-20 at 16 52 32

With options: (Free text entry is still allowed - you're not restricted to just the options)
CleanShot 2024-05-20 at 16 53 05

(Note: vue-select has a noDrop prop, but I got JS errors when using that and it seems fine when using the dropdownShouldOpen prop.)

@jasonvarga jasonvarga merged commit d3333ec into 5.x May 20, 2024
31 checks passed
@jasonvarga jasonvarga deleted the taggable-tweaks branch May 20, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants