Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #9933 I noticed a couple of little things that would be nice to address.
First, setting to close on select. This mimics how the relationship fieldtype works when in taggable mode.
The issue is that when you enter a tag, the dropdown doesn't close, so you can't see the values until you manually close it by hitting escape or clicking away.
Before:
After:
The other thing is that the dropdown is visible even if there are no options. It's not really useful. You can see this in the previous gif. Now you'll only see the dropdown if there are options.
No options:
With options: (Free text entry is still allowed - you're not restricted to just the options)
(Note: vue-select has a
noDrop
prop, but I got JS errors when using that and it seems fine when using thedropdownShouldOpen
prop.)