[5.x] Change method visibility in AbstractAugmented class
#10414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerni
changed the title
AbstractAugmented classAbstractAugmented class
This was referenced Jul 8, 2024
|
Can you give an example of what you'd be returning? |
|
See here: https://github.com/aerni/statamic-advanced-seo/pull/160/files. I need to attach a dummy fieldtype to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9636 introduced a refactor to the
AbstractAugmentedclass that broke a custom augmented class of mine. I need to be able to customize the returnedValueobject. This used to be possible by overriding thewrapValuemethod. However, the PR added some new methods that are currentlyprivateand can't be overridden.This PR changes the visibility of those methods to
protected. I talked to @JohnathonKoster about it and got green lights for this change.