Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Update facade docblocks #10739

Merged
merged 6 commits into from
Sep 2, 2024
Merged

[5.x] Update facade docblocks #10739

merged 6 commits into from
Sep 2, 2024

Conversation

duncanmcclean
Copy link
Member

Last weekend, I noticed that a lot of our docblocks on our facades were out-of-date - missing methods, methods which no longer exist, misleading types.

I thought I'd tidy them up.

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You updated more than just docblocks. You've added typehints to some methods which are breaking changes, like you can see from the tests failing.

@duncanmcclean
Copy link
Member Author

You updated more than just docblocks. You've added typehints to some methods which are breaking changes, like you can see from the tests failing.

Removed the extra types! This is just the docblock updates now.

@jasonvarga jasonvarga merged commit baea8d3 into 5.x Sep 2, 2024
17 checks passed
@jasonvarga jasonvarga deleted the update-facade-docblocks branch September 2, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants