Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globals tweaks #1659

Merged
merged 9 commits into from
Apr 10, 2020
Merged

Globals tweaks #1659

merged 9 commits into from
Apr 10, 2020

Commits on Apr 3, 2020

  1. Clear up some errors when theres no fields or data

    - Props want objects, but when json encoding empty arrays they become arrays.
    - Prevent rendering of the form when its empty anyway
    jasonvarga committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    ea168c0 View commit details
    Browse the repository at this point in the history
  2. Site selector adjustments...

    - Rename the global site selector
    - Remove extra li elements, fix dropdown positioning.
    - Move the structure site selector up a level. It's generic enough. The global set publish form will use it.
    jasonvarga committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    14338ea View commit details
    Browse the repository at this point in the history
  3. Globals adjustments ...

    - Remove ID from globals. Having the handle is nicer in most cases. The ID was there so if you rename the handle things wouldnt break. Things will break anyway if you're renaming the handle.
    - Global sets id method is now just a getter (like collections). It aliases the handle.
    - Adjust global routes and controllers. The variables controller handles the publish form. The globals controller now deals with global sets themselves.
    - Dedicated configure/edit form instead of a stack. That doesn't happen anywhere else anymore.
    - Moved controllers into namespace
    - Multisite fixes. Some things were applied to the entry publish form but not carried over to the globals
    - Scrap the localization logic. It will work like navs. When you configure the global, it will create the appropriate localized files. Rather than being created on the fly when you use the switcher. (The creation step hasn't been done yet.)
    
    ps. sorry for megacommit
    jasonvarga committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    196c8e2 View commit details
    Browse the repository at this point in the history
  4. replace helper usage

    jasonvarga committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    1009953 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. GlobalSets work similar to navs now. If the file exists, it exists fo…

    …r that site. Doesn't need to be defined on the set level.
    jasonvarga committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    7de2dc5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b9098ef View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary method

    jasonvarga committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    4e20835 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Remove nulls

    jasonvarga committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    42c4069 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    424e11e View commit details
    Browse the repository at this point in the history