-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globals tweaks #1659
Merged
Merged
Globals tweaks #1659
Commits on Apr 3, 2020
-
Clear up some errors when theres no fields or data
- Props want objects, but when json encoding empty arrays they become arrays. - Prevent rendering of the form when its empty anyway
Configuration menu - View commit details
-
Copy full SHA for ea168c0 - Browse repository at this point
Copy the full SHA ea168c0View commit details -
- Rename the global site selector - Remove extra li elements, fix dropdown positioning. - Move the structure site selector up a level. It's generic enough. The global set publish form will use it.
Configuration menu - View commit details
-
Copy full SHA for 14338ea - Browse repository at this point
Copy the full SHA 14338eaView commit details -
- Remove ID from globals. Having the handle is nicer in most cases. The ID was there so if you rename the handle things wouldnt break. Things will break anyway if you're renaming the handle. - Global sets id method is now just a getter (like collections). It aliases the handle. - Adjust global routes and controllers. The variables controller handles the publish form. The globals controller now deals with global sets themselves. - Dedicated configure/edit form instead of a stack. That doesn't happen anywhere else anymore. - Moved controllers into namespace - Multisite fixes. Some things were applied to the entry publish form but not carried over to the globals - Scrap the localization logic. It will work like navs. When you configure the global, it will create the appropriate localized files. Rather than being created on the fly when you use the switcher. (The creation step hasn't been done yet.) ps. sorry for megacommit
Configuration menu - View commit details
-
Copy full SHA for 196c8e2 - Browse repository at this point
Copy the full SHA 196c8e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1009953 - Browse repository at this point
Copy the full SHA 1009953View commit details
Commits on Apr 9, 2020
-
GlobalSets work similar to navs now. If the file exists, it exists fo…
…r that site. Doesn't need to be defined on the set level.
Configuration menu - View commit details
-
Copy full SHA for 7de2dc5 - Browse repository at this point
Copy the full SHA 7de2dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9098ef - Browse repository at this point
Copy the full SHA b9098efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e20835 - Browse repository at this point
Copy the full SHA 4e20835View commit details
Commits on Apr 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 42c4069 - Browse repository at this point
Copy the full SHA 42c4069View commit details -
Configuration menu - View commit details
-
Copy full SHA for 424e11e - Browse repository at this point
Copy the full SHA 424e11eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.