Fix reordering entries in a collection named literally collection #6371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically reverts #4978 and fixes #4495.
#4978 only seemed to fix the problem when the collection had the word
collection
within it. e.g.my_collection
. However it was still broken when the handle was literally justcollection
.Removing the "fix" makes it works for all scenarios:
collection
collection
in it, likemy_collection
pages
Something else in the codebase must have resolved #4495 since the issue was originally opened.
Added test coverage to prevent another regression.