Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reordering entries in a collection named literally collection #6371

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Jul 23, 2022

This basically reverts #4978 and fixes #4495.

#4978 only seemed to fix the problem when the collection had the word collection within it. e.g. my_collection. However it was still broken when the handle was literally just collection.

Removing the "fix" makes it works for all scenarios:

  • Handle named literally collection
  • Handle with collection in it, like my_collection
  • Completely different handle like pages

Something else in the codebase must have resolved #4495 since the issue was originally opened.

Added test coverage to prevent another regression.

@jasonvarga jasonvarga merged commit 41891f2 into 3.3 Jul 23, 2022
@jasonvarga jasonvarga deleted the fix/4495 branch July 23, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't reorder entries in a collection with the word collection
1 participant