Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Add console import for file based groups and roles to database #6774

Merged

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Sep 23, 2022

Added an import php please eloquent:import-groups and php please eloquent:import-roles to transfer file based roles and groups to eloquent driven.

Requires: #5686
Related: #6729

If #6506 merges, then the group import will need to be updated to support the import of data.

@ryanmitchell ryanmitchell changed the base branch from 3.3 to 4.x August 15, 2023 10:11
@ryanmitchell ryanmitchell changed the title Add console import for file based groups and roles to database [4.x] Add console import for file based groups and roles to database Jan 23, 2024
@ryanmitchell ryanmitchell marked this pull request as ready for review January 23, 2024 20:33
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has made me notice that data support wasn't added to #5686.

I've removed the data() import here and I'll fix all the data-related stuff in a separate PR.

Other than that, I made to make a couple of small fixes - but this is good to go other than data. 👌 Thanks.

@jasonvarga jasonvarga merged commit ecfe589 into statamic:4.x Jan 24, 2024
18 checks passed
@ryanmitchell
Copy link
Contributor Author

Ah yes. Too many overlapping PRs!
thanks for tidying it up.

@ryanmitchell ryanmitchell deleted the feature/import-groups-and-roles-to-eloquent branch January 24, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants