Browser sync proxy #261
Merged
Browser sync proxy #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jescalan
reviewed
Nov 6, 2017
| ignored: Joi.array().default('node_modules') | ||
| }), | ||
| server: Joi.object().default({}), | ||
| server: Joi.default({}) |
There was a problem hiding this comment.
I guess because it can be false now?
There was a problem hiding this comment.
Yeah, we need to default to empty object before we check Joi.exist('proxy'), otherwise that check passess, the server is set to {} afterwards and then browser-sync will fail the proxy option (Server must be false with proxy option…)
|
🎉 |
|
👬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
Config.server.proxyoption for browser-syn, to allow proxy to different server in the background (which then handles serving the spike built files). This option must bestringorobjectwith keytarget, and if is defined,Config.server.servermust be set tofalse.I added all of this to Joi schema and put the
Config.server.server.baseDirsetting behind check for existence of server.