Skip to content

Conversation

djeglin
Copy link
Contributor

@djeglin djeglin commented Nov 21, 2016

I have changed lib/watch.js to properly pass the port variable from the command line through to browsersync.

Copy link
Member

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple things:

  • Does this still work well even when there isn't a port option passed in?
  • Could you add a test for this option to prevent regression? Let me know if the test structure is confusing 😁

Copy link
Member

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants