Skip to content

fix watch to properly pass port variable to browsersync opts #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2016
Merged

fix watch to properly pass port variable to browsersync opts #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4892bad
fix watch to properly pass port variable to browsersync opts
djeglin Nov 21, 2016
ce6eba2
update spacing for code linting
djeglin Nov 21, 2016
aecc715
add tests for watch command - with and without port argument
djeglin Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = function (Spike, args) {
const project = new Spike({ root: args.path, env: args.env })
const project = new Spike({ root: args.path, env: args.env, server: { port: args.port } })
process.nextTick(() => project.watch())
return project
}
12 changes: 12 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ test.cb('watch', (t) => {
cli.on('warning', t.end)
cli.on('compile', (res) => {
t.is(res, 'watch mock')
t.falsy(mock.opts.server.port)
t.end()
})

Expand All @@ -138,6 +139,17 @@ test.cb('watch with env option', (t) => {
cli.run('watch -e production')
})

test.cb('watch with port option', (t) => {
cli.on('error', t.end)
cli.on('warning', t.end)
cli.on('compile', (res) => {
t.is(mock.opts.server.port, 1118)
t.end()
})

cli.run('watch -p 1118')
})

test.cb('add', (t) => {
cli.on('error', t.end)
cli.on('warning', t.end)
Expand Down