You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Breaking:LOCheck.SourceTag is uint?, the number rippled sends for the UInt32; it was string, which no Check carrying a SourceTag could be read into (mainnet CheckCash E14C0351A673C27F6A1F0795EB7D665339F6B8C7EDB84E812DCA795127F25E1F). Migration: read the tag as a number
LedgerRules.FromNodeAsync sets FixAMMv1_1 whatever the feature command reports: rippled develop retired the amendment (XRPL_RETIRE_FIX(AMMv1_1), XRPLF/rippled#8226). Docs: Amounts-Guide (both languages) says so
RippleStateFlags is a uint enum, as the other ledger flag enums are; as an int it could not hold a UInt32 Flags with the top bit set
Breaking:TransactionResponseConverter raises JsonException when a transaction cannot be read, with the transaction type and hash in the message and the original exception as InnerException; it returned the object built from TransactionType with every other field empty. What breaks: TxV1 and AccountTransactions raise XrplException ("Failed to deserialize response", this JsonException as InnerException) where they returned a result, a transaction stream message goes to OnError (streamHandlerError, the frame text in data) instead of OnTransaction, and the OrderBookStream.Transaction getter raises the JsonException. Migration: catch XrplException around those requests and JsonException around the getter, and handle streamHandlerError in OnError to see the transactions a stream could not read
Tests: TestUCheckSourceTag reads the CheckCash above through TxV1 and TxV2; tx_check_cash_raw.json and tx_check_cash_v1_raw.json join the TestUResponseFidelity corpus; TestULedgerEntryFieldsConformance.TestULedgerEntryModels_ReadIntegerFieldsAsRippledSendsThem reads every UInt8, UInt16, UInt32, Int32 and UInt64 field of every ledger object model from the value rippled sends at the top of its range; TestUTransactionResponseConverter expects the exception instead of the empty object; TestULedgerRules.RetiredFixAMMv1_1IsOnWhateverTheNodeReports