display group chat system message using new ui #20787

jo-mut · 2024-07-17T13:48:45Z

fixes #20488

Summary

This pr. displays group chat system message using the new ui

Before and after screenshots comparison

Figma

https://www.figma.com/design/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=11522-138410&t=nzRl5xrbCFgAZrgX-4

status: ready

status-im-auto · 2024-07-17T13:53:43Z

Jenkins Builds

Click to see older builds (41)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7ec6d94`	#1	2024-07-17 13:53:39	~4 min	`tests`	📄`log`
✔️	`7ec6d94`	#1	2024-07-17 13:55:55	~6 min	`android`	🤖`apk` 📲
✔️	`7ec6d94`	#1	2024-07-17 13:57:55	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`7ec6d94`	#1	2024-07-17 13:59:02	~9 min	`ios`	📱`ipa` 📲

✔️	`3e8567e`	#2	2024-07-23 10:21:34	~4 min	`tests`	📄`log`
✔️	`3e8567e`	#2	2024-07-23 10:23:44	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`3e8567e`	#2	2024-07-23 10:23:57	~7 min	`android`	🤖`apk` 📲
✔️	`3e8567e`	#2	2024-07-23 10:25:56	~9 min	`ios`	📱`ipa` 📲

❌	`a291c66`	#3	2024-07-23 12:32:40	~4 min	`tests`	📄`log`
✔️	`a291c66`	#3	2024-07-23 12:35:19	~7 min	`android`	🤖`apk` 📲
✔️	`a291c66`	#3	2024-07-23 12:36:31	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`a291c66`	#3	2024-07-23 12:37:46	~9 min	`ios`	📱`ipa` 📲

✔️	`cb06a5b`	#4	2024-07-24 19:15:41	~4 min	`tests`	📄`log`
✔️	`cb06a5b`	#4	2024-07-24 19:18:57	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`cb06a5b`	#4	2024-07-24 19:19:03	~7 min	`android`	🤖`apk` 📲
✔️	`cb06a5b`	#4	2024-07-24 19:20:24	~9 min	`ios`	📱`ipa` 📲

❌	`0182dab`	#5	2024-07-25 12:42:31	~4 min	`tests`	📄`log`

❌	`9eb486e`	#6	2024-07-25 12:46:53	~3 min	`tests`	📄`log`
✔️	`9eb486e`	#6	2024-07-25 12:50:35	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`9eb486e`	#6	2024-07-25 12:50:50	~7 min	`android`	🤖`apk` 📲
❌	`9eb486e`	#6	2024-07-25 12:59:06	~15 min	`ios`	📄`log`

✔️	`b1410f0`	#7	2024-07-25 14:14:09	~7 min	`tests`	📄`log`
✔️	`b1410f0`	#7	2024-07-25 14:15:58	~9 min	`ios`	📱`ipa` 📲
✔️	`b1410f0`	#7	2024-07-25 14:16:36	~10 min	`android`	🤖`apk` 📲
✔️	`b1410f0`	#7	2024-07-25 14:17:50	~11 min	`android-e2e`	🤖`apk` 📲

✔️	`cad6087`	#8	2024-07-26 09:48:16	~4 min	`tests`	📄`log`

❌	`82629c1`	#9	2024-07-26 09:54:58	~4 min	`tests`	📄`log`
✔️	`82629c1`	#9	2024-07-26 09:58:43	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`82629c1`	#9	2024-07-26 10:02:03	~11 min	`ios`	📱`ipa` 📲

❌	`dcdcfe0`	#10	2024-07-26 10:22:42	~3 min	`tests`	📄`log`
✔️	`dcdcfe0`	#10	2024-07-26 10:26:06	~6 min	`android`	🤖`apk` 📲
✔️	`dcdcfe0`	#10	2024-07-26 10:26:17	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`dcdcfe0`	#10	2024-07-26 10:30:24	~11 min	`ios`	📱`ipa` 📲

❌	`24fd8d3`	#11	2024-07-26 18:12:40	~2 min	`tests`	📄`log`
✔️	`24fd8d3`	#11	2024-07-26 18:17:22	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`24fd8d3`	#11	2024-07-26 18:21:16	~11 min	`ios`	📱`ipa` 📲

❌	`136020c`	#12	2024-07-26 18:34:57	~2 min	`tests`	📄`log`

❌	`ac8fe1a`	#13	2024-07-26 18:38:30	~2 min	`tests`	📄`log`
✔️	`ac8fe1a`	#13	2024-07-26 18:42:32	~6 min	`android`	🤖`apk` 📲
✔️	`ac8fe1a`	#13	2024-07-26 18:42:52	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ac8fe1a`	#13	2024-07-26 18:46:44	~11 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`14414a6`	#14	2024-07-26 18:57:42	~2 min	`tests`	📄`log`

✔️	`8c3aa62`	#15	2024-07-26 19:05:13	~4 min	`tests`	📄`log`
✔️	`8c3aa62`	#15	2024-07-26 19:07:34	~6 min	`android`	🤖`apk` 📲
✔️	`8c3aa62`	#15	2024-07-26 19:08:10	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`8c3aa62`	#15	2024-07-26 19:12:12	~11 min	`ios`	📱`ipa` 📲

ilmotta

I made a few minor suggestions, but from a superficial look, the UI looks good @jo-mut.

src/quo/components/messages/system_message/view.cljs

src/status_im/contexts/chat/messenger/messages/content/view.cljs

status-im-auto · 2024-07-25T13:39:28Z

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 1
Passed tests: 5

IDs of failed tests: 727230

IDs of expected to fail tests: 727232

Failed tests (1)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
Device 2: `Text` is `0.01779 ETH`

critical/test_wallet.py:184: in test_wallet_send_asset_from_drawer
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4788 but expected to be 0.4789

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find EditBox by accessibility id: add-address-to-watch
Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (5)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-07-25T19:08:23Z

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 1
Passed tests: 6

IDs of expected to fail tests: 727232

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find `EditBox` by `accessibility id`: `add-address-to-watch`
Device 1: Type `0x8d2413447ff297d30bdc475f6d5cb00254685aae` to `EditBox`

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (6)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

mariia-skrypnyk · 2024-07-26T10:59:01Z

Hi @jo-mut !

New UI looks much prettier!

Just a little issue:

ISSUE 1: The comma is moved to the second line

Expected result: comma should not be moved alone to the next line

jo-mut · 2024-07-26T11:02:45Z

Hi @jo-mut !

New UI looks much prettier!

Just a little issue:

ISSUE 1: The comma is moved to the second line
Expected result: comma should not be moved alone to the next line

thank you @mariia-skrypnyk. Let me see how to fix this one

churik · 2024-07-26T13:05:09Z

@mariia-skrypnyk how do you feel about merging this like it is and fixing issue as a followup, as it indeed much better?

mariia-skrypnyk · 2024-07-26T13:07:40Z

@churik yes, according to our situation it's worth merging as it is!
@jo-mut will create a follow up.

Please, merge your PR.
Good job!

churik · 2024-07-26T13:08:23Z

@jo-mut merge this one, yeey :)

Revisions from develop: - 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902) - 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721) - 8c2d539 Enabling WalletConnect feature flag (#20906) - 67c83b1 fix(wallet): remove edit routes button in bridging (#20874) - 11a84ba feat(wallet): disable complex routing (#20901) - 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846) - 4586f80 Add toggle in advanced settings for mobile data - 55c620e fix: create password for small screen (#20645) - 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862) - 9065395 chore(settings): Disable telemetry option (#20881) - d27ab75 fix_:display group message using the new ui (#20787) - c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683) - 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845) - a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888) - a671c70 fix broken screen and navigation when syncing fails (#20887) - a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799) - 2e9fa22 feat: wallet router v2 (#20631) - 737d8c4 rename sub to fix error when requesting to join community (#20868) - 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883) - c1d2d44 perf: Fix app freeze after login (#20729) - 0fed811 e2e: updated testnet switching and added one test into smoke - 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854) - be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875) - eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873) - fe54a25 fix: not clearing network & web3-wallet on logout (#20886) - 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836) - 2ffbdac WalletConnect show expired toast (#20857) - 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867) - ff88049 Fix WalletConnect header alignment on Android (#20860) - cee2124 WalletConnect no internet edge-cases (#20826) - 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825) - 4989c92 fix_: Adding own address as saved addresses (#20839)

jo-mut self-assigned this Jul 18, 2024

jo-mut force-pushed the fix/group-chat-list-item branch from 7ec6d94 to 3e8567e Compare July 23, 2024 10:16

jo-mut marked this pull request as ready for review July 23, 2024 12:27

jo-mut force-pushed the fix/group-chat-list-item branch from 3e8567e to a291c66 Compare July 23, 2024 12:27

jo-mut requested review from alwx, yqrashawn, Parveshdhull and ilmotta July 23, 2024 12:28

jo-mut force-pushed the fix/group-chat-list-item branch from a291c66 to cb06a5b Compare July 24, 2024 19:10

jo-mut added the request-manual-qa label Jul 24, 2024

ilmotta approved these changes Jul 25, 2024

View reviewed changes

jo-mut force-pushed the fix/group-chat-list-item branch from cb06a5b to 0182dab Compare July 25, 2024 12:37

jo-mut force-pushed the fix/group-chat-list-item branch from 0182dab to 9eb486e Compare July 25, 2024 12:43

jo-mut force-pushed the fix/group-chat-list-item branch from 9eb486e to b1410f0 Compare July 25, 2024 14:06

mariia-skrypnyk self-assigned this Jul 26, 2024

mariia-skrypnyk force-pushed the fix/group-chat-list-item branch from b1410f0 to cad6087 Compare July 26, 2024 09:42

jo-mut force-pushed the fix/group-chat-list-item branch 2 times, most recently from 82629c1 to dcdcfe0 Compare July 26, 2024 10:18

mariia-skrypnyk added the Tested - Issues label Jul 26, 2024

mariia-skrypnyk added the followup-required label Jul 26, 2024

mariia-skrypnyk added Tested - OK and removed Tested - Issues labels Jul 26, 2024

jo-mut force-pushed the fix/group-chat-list-item branch 4 times, most recently from ac8fe1a to 14414a6 Compare July 26, 2024 18:54

fix_:display group message using the new ui

8c3aa62

jo-mut force-pushed the fix/group-chat-list-item branch from 14414a6 to 8c3aa62 Compare July 26, 2024 19:00

jo-mut merged commit d27ab75 into develop Jul 26, 2024
5 checks passed

jo-mut deleted the fix/group-chat-list-item branch July 26, 2024 19:14

jo-mut mentioned this pull request Jul 28, 2024

Comma should not be the start of a new line #20904

Closed

ilmotta pushed a commit that referenced this pull request Jul 28, 2024

fix_:display group message using the new ui (#20787)

6fd6eaa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

display group chat system message using new ui #20787

display group chat system message using new ui #20787

jo-mut commented Jul 17, 2024 •

edited

Loading

status-im-auto commented Jul 17, 2024 •

edited

Loading

ilmotta left a comment

status-im-auto commented Jul 25, 2024

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented Jul 25, 2024

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

mariia-skrypnyk commented Jul 26, 2024 •

edited

Loading

jo-mut commented Jul 26, 2024

churik commented Jul 26, 2024

mariia-skrypnyk commented Jul 26, 2024 •

edited

Loading

churik commented Jul 26, 2024

display group chat system message using new ui #20787

display group chat system message using new ui #20787

Conversation

jo-mut commented Jul 17, 2024 • edited Loading

Summary

Before and after screenshots comparison

Figma

status-im-auto commented Jul 17, 2024 • edited Loading

Jenkins Builds

ilmotta left a comment

Choose a reason for hiding this comment

status-im-auto commented Jul 25, 2024

71% of end-end tests have passed

Failed tests (1)

Class TestWalletMultipleDevice:

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (5)

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented Jul 25, 2024

86% of end-end tests have passed

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (6)

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

mariia-skrypnyk commented Jul 26, 2024 • edited Loading

jo-mut commented Jul 26, 2024

churik commented Jul 26, 2024

mariia-skrypnyk commented Jul 26, 2024 • edited Loading

churik commented Jul 26, 2024

jo-mut commented Jul 17, 2024 •

edited

Loading

status-im-auto commented Jul 17, 2024 •

edited

Loading

mariia-skrypnyk commented Jul 26, 2024 •

edited

Loading

mariia-skrypnyk commented Jul 26, 2024 •

edited

Loading