Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The missed keypairs are shown in the key pair list screen #20524

Closed
VolodLytvynenko opened this issue Jun 21, 2024 · 0 comments · Fixed by #20888
Closed

The missed keypairs are shown in the key pair list screen #20524

VolodLytvynenko opened this issue Jun 21, 2024 · 0 comments · Fixed by #20888
Assignees
@mohsen-ghafouri
Labels
low-prio mobile-core
Milestone
2.30.0

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Jun 21, 2024 •
edited
Loading

Steps:

  1. Device B is synced with Device A
  2. Device A creates an additional wallet address importing seed phrases or generation of new keypairs
  3. Device B updates the wallet (now all addresses are shown and Device B sees them as non-imported)
  4. Device B attempts to create derived accounts for such non-imported accounts

Actual result:

Device B sees the list of missed keypairs in the keypair list

image

nonimported.mp4

Expected result:

The missed keypairs are not shown for Device B

reference https://discord.com/channels/624634427930312714/852533718790570015/1253377516102615160

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

ENV:

NIghtly [21 Jun 2024]
@churik churik added this to the 2.30.0 Beta milestone Jun 24, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this Jul 23, 2024
mohsen-ghafouri added a commit that referenced this issue Jul 25, 2024
@mohsen-ghafouri
[#20524] fix: the missed keypairs are shown in the key pair list screen
86016cd
@mohsen-ghafouri mohsen-ghafouri mentioned this issue Jul 25, 2024
Merged
mariia-skrypnyk pushed a commit that referenced this issue Jul 26, 2024
@mohsen-ghafouri @mariia-skrypnyk
[#20524] fix: the missed keypairs are shown in the key pair list screen
a24c960
mohsen-ghafouri added a commit that referenced this issue Jul 26, 2024
@mohsen-ghafouri
[#20524] fix: the missed keypairs are shown in the key pair list screen
cdcc29f
mohsen-ghafouri added a commit that referenced this issue Jul 26, 2024
@mohsen-ghafouri
[#20524] fix: the missed keypairs are shown in the key pair list screen
4cd82e8
mohsen-ghafouri added a commit that referenced this issue Jul 26, 2024
@mohsen-ghafouri
[#20524] fix: the missed keypairs are shown in the key pair list scre…
a6d3fc3 
…en (#20888)
ilmotta pushed a commit that referenced this issue Jul 28, 2024
@mohsen-ghafouri @ilmotta
[#20524] fix: the missed keypairs are shown in the key pair list scre…
b4e84f5 
…en (#20888)
ilmotta added a commit that referenced this issue Jul 30, 2024
@ilmotta
Update release branch 2.30.x (#20903)
0f15c01 
Revisions from develop:

- 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902)
- 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721)
- 8c2d539 Enabling WalletConnect feature flag (#20906)
- 67c83b1 fix(wallet): remove edit routes button in bridging (#20874)
- 11a84ba feat(wallet): disable complex routing (#20901)
- 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846)
- 4586f80 Add toggle in advanced settings for mobile data
- 55c620e fix: create password for small screen (#20645)
- 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862)
- 9065395 chore(settings): Disable telemetry option (#20881)
- d27ab75 fix_:display group message using the new ui (#20787)
- c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683)
- 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845)
- a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888)
- a671c70 fix broken screen and navigation when syncing fails (#20887)
- a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799)
- 2e9fa22 feat: wallet router v2 (#20631)
- 737d8c4 rename sub to fix error when requesting to join community (#20868)
- 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883)
- c1d2d44 perf: Fix app freeze after login (#20729)
- 0fed811 e2e: updated testnet switching and added one test into smoke
- 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854)
- be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875)
- eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873)
- fe54a25 fix: not clearing network & web3-wallet on logout (#20886)
- 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836)
- 2ffbdac WalletConnect show expired toast (#20857)
- 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867)
- ff88049 Fix WalletConnect header alignment on Android (#20860)
- cee2124 WalletConnect no internet edge-cases (#20826)
- 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825)
- 4989c92 fix_: Adding own address as saved addresses (#20839)
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
low-prio mobile-core
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0
Development

Successfully merging a pull request may close this issue.

[#20524] fix: the missed keypairs are shown in the key pair list screen status-im/status-mobile
4 participants
@ilmotta @churik @VolodLytvynenko @mohsen-ghafouri