[#20804] linear gradient exception #20854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulisesmac
requested review from
ilmotta,
briansztamfater,
smohamedjavid and
J-Son89
ulisesmac
commented
Jul 22, 2024
Comment on lines
67
to
+69
| [linear-gradient/linear-gradient | ||
| (assoc {:style (style/container loading? theme size)} | ||
| :colors | ||
| (linear-gradient-props theme customization-color)) | ||
| {:style (style/container loading? theme size) | ||
| :colors (linear-gradient-props theme customization-color)} |
There was a problem hiding this comment.
Just fixing code style, this assoc was never needed
Jenkins BuildsClick to see older builds (9)
|
ulisesmac
commented
Jul 22, 2024
ulisesmac
commented
Jul 22, 2024
ilmotta
approved these changes
Jul 23, 2024
briansztamfater
approved these changes
Jul 23, 2024
ulisesmac
force-pushed
the
20804-Linear-gradient-exception
branch
from
cc7f45e
to
0115d53
Compare
ulisesmac
force-pushed
the
20804-Linear-gradient-exception
branch
from
886c23c
to
a07d21c
Compare
86% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (6)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
|
|
Hi @ulisesmac thanks for the PR! Checked on iOS and Android - app works without crashing! |
ilmotta
pushed a commit
that referenced
this pull request
Jul 28, 2024
…account cards (#20854) * Create a linear-gradient wrapper to avoid crashes and notify color errors * Fix references to the flamingo color * Add customization color fallback
ilmotta
added a commit
that referenced
this pull request
Jul 30, 2024
Revisions from develop: - 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902) - 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721) - 8c2d539 Enabling WalletConnect feature flag (#20906) - 67c83b1 fix(wallet): remove edit routes button in bridging (#20874) - 11a84ba feat(wallet): disable complex routing (#20901) - 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846) - 4586f80 Add toggle in advanced settings for mobile data - 55c620e fix: create password for small screen (#20645) - 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862) - 9065395 chore(settings): Disable telemetry option (#20881) - d27ab75 fix_:display group message using the new ui (#20787) - c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683) - 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845) - a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888) - a671c70 fix broken screen and navigation when syncing fails (#20887) - a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799) - 2e9fa22 feat: wallet router v2 (#20631) - 737d8c4 rename sub to fix error when requesting to join community (#20868) - 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883) - c1d2d44 perf: Fix app freeze after login (#20729) - 0fed811 e2e: updated testnet switching and added one test into smoke - 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854) - be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875) - eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873) - fe54a25 fix: not clearing network & web3-wallet on logout (#20886) - 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836) - 2ffbdac WalletConnect show expired toast (#20857) - 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867) - ff88049 Fix WalletConnect header alignment on Android (#20860) - cee2124 WalletConnect no internet edge-cases (#20826) - 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825) - 4989c92 fix_: Adding own address as saved addresses (#20839)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20804
Summary
This PR adds a safety wrapper for the Linear Gradient component, as we've had multiple issues due to invalid colors being passed to the component.
Now when an invalid color is found it's substituted by
"transparent"so that the app doesn't crash, and an error with the given wrong colors is logged.Additionally, this PR solves another problem: we have mistakenly named the
flamingocolor in our codebase, it's called aspinkin figma (https://www.figma.com/design/v98g9ZiaSHYUdKWrbFg9eM/Foundations?node-id=619-10064&t=aYNJmP11jE8eqoh8-0)When we received
:pinkfrom status go it was resolved asnilso some components didn't render as expected (such as theLinearGradientcrashing).Review notes
IMPORTANT
The
yin-yangcolor is still not supported on mobile, but our accounts cards aren't crashing now :)Testing notes
Steps to test
status: ready