Reject wallet-connect request by dragging the modal down (#20763) #20836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (45)
|
clauxx
reviewed
Jul 22, 2024
|
@shivekkhurana @clauxx ready to be reviewed |
clauxx
approved these changes
Jul 23, 2024
71% of end-end tests have passedFailed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
|
alwx
force-pushed
the
bugfix/20763
branch
2 times, most recently
from
d4cebd3
to
c02680d
Compare
|
@alwx please take a look at the issues: ISSUE 1 Requests are not rejected neither by dragging the modal nor by closing itTest dApp used for testing https://react-app.walletconnect.com/ Also can be reproduced on real dApps https://opensea.io/ and https://dydx.trade/DYDX. Some requests are triggered during connecting to those dApps. Steps:
Actual result: request is not rejected. requests_not_rejected.mp4 |
ISSUE 2 Wallet connect proposal is not rejected on some dApps' sideFor now I have found one example https://yearn.fi/ Steps:
Actual result: nothing happens on sApp side, QR is still open. decline_proposal.mp4 |
|
@pavloburykh ready to be checked again |
|
@alwx ISSUE 1 is fixed. ISSUE 2 still reproducible for me. Please take a look at some new issues. ISSUE 3 Top bar menu in not responding after closing request modalSteps:
Actual result: top bar menu elements (i.e. profile, activity center, scanner) are not responding telegram-cloud-document-2-5262829113772628161.mp4 |
ISSUE 4 Password modal does not disappear after confirming the request
Actual result: password modal does not disappear telegram-cloud-document-2-5262829113772628165.mp4 |
ISSUE 5 New requests do not appear in Status app until relogin when previous request has been rejectedSteps:
Actual result: new request does not appear until re-login request_not_appear.mp4 |
alwx
force-pushed
the
bugfix/20763
branch
2 times, most recently
from
6f0be98
to
fd9979d
Compare
|
@alwx seems like all these issues may come from the modal being dismissed twice. I had the same issue in my previous PR. A quick fix could be to check if the modal-id is present in the atom before we dismiss the modal by id, but this could be the problem that I tried to explain with this approach, where some action may be triggered twice. It's possible this came from rebasing develop, but still it's a sign that we might have to rethink this later. |
|
@alwx I have a quick fix for issues 3 to 5 in this commit (branched off from this one). It's pretty ugly IMO, but at least it's only a few lines and will be easier to fix it properly later. What do you think? @pavloburykh about issue 2, I guess if there's a small number of dapps that don't react to our disconnect, there's not much we can do at the moment. Might be best to have a separate issue for it for the next milestone. |
|
Issue 4 was fixed yesterday; issue 3 and 5 are fixed now as well. |
ilmotta
pushed a commit
that referenced
this pull request
Jul 28, 2024
ilmotta
added a commit
that referenced
this pull request
Jul 30, 2024
Revisions from develop: - 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902) - 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721) - 8c2d539 Enabling WalletConnect feature flag (#20906) - 67c83b1 fix(wallet): remove edit routes button in bridging (#20874) - 11a84ba feat(wallet): disable complex routing (#20901) - 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846) - 4586f80 Add toggle in advanced settings for mobile data - 55c620e fix: create password for small screen (#20645) - 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862) - 9065395 chore(settings): Disable telemetry option (#20881) - d27ab75 fix_:display group message using the new ui (#20787) - c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683) - 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845) - a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888) - a671c70 fix broken screen and navigation when syncing fails (#20887) - a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799) - 2e9fa22 feat: wallet router v2 (#20631) - 737d8c4 rename sub to fix error when requesting to join community (#20868) - 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883) - c1d2d44 perf: Fix app freeze after login (#20729) - 0fed811 e2e: updated testnet switching and added one test into smoke - 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854) - be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875) - eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873) - fe54a25 fix: not clearing network & web3-wallet on logout (#20886) - 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836) - 2ffbdac WalletConnect show expired toast (#20857) - 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867) - ff88049 Fix WalletConnect header alignment on Android (#20860) - cee2124 WalletConnect no internet edge-cases (#20826) - 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825) - 4989c92 fix_: Adding own address as saved addresses (#20839)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20763
fixes #20865
Platforms
status: ready