[#20524] fix: the missed keypairs are shown in the key pair list screen #20888

mohsen-ghafouri · 2024-07-25T14:31:27Z

fixes #20524

Summary

The missed keypairs are shown in the key pair list screen, we should eliminate missing keypairs from the list

Areas that maybe impacted

Add Wallet Account -> Keypairs list

Steps to test

Device B is synced with Device A
Device A creates an additional wallet address importing seed phrases or generation of new keypairs
Device B updates the wallet (now all addresses are shown and Device B sees them as non-imported)
Device B attempts to create derived accounts for such non-imported accounts

Result

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-25.at.17.52.22.mp4

status: ready

status-im-auto · 2024-07-25T14:36:48Z

Jenkins Builds

Click to see older builds (5)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`86016cd`	#1	2024-07-25 14:36:44	~4 min	`tests`	📄`log`
✔️	`86016cd`	#1	2024-07-25 14:39:46	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`86016cd`	#1	2024-07-25 14:39:48	~8 min	`android`	🤖`apk` 📲
✔️	`86016cd`	#1	2024-07-25 14:42:42	~10 min	`ios`	📱`ipa` 📲

✔️	`a24c960`	#2	2024-07-26 13:58:27	~18 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`cdcc29f`	#3	2024-07-26 14:12:48	~11 min	`ios`	📱`ipa` 📲
✔️	`cdcc29f`	#3	2024-07-26 14:15:50	~14 min	`android-e2e`	🤖`apk` 📲
✔️	`cdcc29f`	#3	2024-07-26 14:17:28	~16 min	`android`	🤖`apk` 📲
✔️	`cdcc29f`	#3	2024-07-26 14:20:46	~19 min	`tests`	📄`log`

❌	`4cd82e8`	#4	2024-07-26 15:20:55	~5 min	`ios`	📄`log`
✔️	`4cd82e8`	#4	2024-07-26 15:21:46	~6 min	`tests`	📄`log`
✔️	`4cd82e8`	#4	2024-07-26 15:22:59	~7 min	`android`	🤖`apk` 📲
✔️	`4cd82e8`	#4	2024-07-26 15:24:44	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`4cd82e8`	#5	2024-07-26 15:39:18	~17 min	`ios`	📱`ipa` 📲

ajayesivan

Looks good!

smohamedjavid

Nice work @mohsen-ghafouri 🙌

status-im-auto · 2024-07-25T15:03:56Z

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 1
Passed tests: 5

IDs of failed tests: 727229

IDs of expected to fail tests: 727232

Failed tests (1)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
Device 2: `Text` is `0.01839 ETH`

critical/test_wallet.py:156: in test_wallet_send_eth
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4779 but expected to be 0.478

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find EditBox by accessibility id: add-address-to-watch
Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (5)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

status-im-auto · 2024-07-25T19:22:11Z

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 1
Passed tests: 6

IDs of expected to fail tests: 727232

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find `EditBox` by `accessibility id`: `add-address-to-watch`
Device 1: Type `0x8d2413447ff297d30bdc475f6d5cb00254685aae` to `EditBox`

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (6)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

mariia-skrypnyk · 2024-07-26T14:39:40Z

Hi @mohsen-ghafouri !

Thanks for help with rebase.
Fix looks good.
Great job!
You can merge your PR.

…en (#20888)

Revisions from develop: - 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902) - 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721) - 8c2d539 Enabling WalletConnect feature flag (#20906) - 67c83b1 fix(wallet): remove edit routes button in bridging (#20874) - 11a84ba feat(wallet): disable complex routing (#20901) - 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846) - 4586f80 Add toggle in advanced settings for mobile data - 55c620e fix: create password for small screen (#20645) - 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862) - 9065395 chore(settings): Disable telemetry option (#20881) - d27ab75 fix_:display group message using the new ui (#20787) - c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683) - 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845) - a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888) - a671c70 fix broken screen and navigation when syncing fails (#20887) - a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799) - 2e9fa22 feat: wallet router v2 (#20631) - 737d8c4 rename sub to fix error when requesting to join community (#20868) - 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883) - c1d2d44 perf: Fix app freeze after login (#20729) - 0fed811 e2e: updated testnet switching and added one test into smoke - 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854) - be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875) - eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873) - fe54a25 fix: not clearing network & web3-wallet on logout (#20886) - 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836) - 2ffbdac WalletConnect show expired toast (#20857) - 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867) - ff88049 Fix WalletConnect header alignment on Android (#20860) - cee2124 WalletConnect no internet edge-cases (#20826) - 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825) - 4989c92 fix_: Adding own address as saved addresses (#20839)

mohsen-ghafouri requested review from vkjr, ajayesivan and smohamedjavid July 25, 2024 14:31

mohsen-ghafouri self-assigned this Jul 25, 2024

ajayesivan approved these changes Jul 25, 2024

View reviewed changes

mohsen-ghafouri added the request-manual-qa label Jul 25, 2024

smohamedjavid approved these changes Jul 25, 2024

View reviewed changes

mariia-skrypnyk self-assigned this Jul 26, 2024

mariia-skrypnyk force-pushed the fix/hide-missing-keypair branch from 86016cd to a24c960 Compare July 26, 2024 13:39

mohsen-ghafouri force-pushed the fix/hide-missing-keypair branch from a24c960 to cdcc29f Compare July 26, 2024 14:00

mariia-skrypnyk added the Tested - OK label Jul 26, 2024

[#20524] fix: the missed keypairs are shown in the key pair list screen

4cd82e8

mohsen-ghafouri force-pushed the fix/hide-missing-keypair branch from cdcc29f to 4cd82e8 Compare July 26, 2024 15:14

mohsen-ghafouri merged commit a6d3fc3 into develop Jul 26, 2024
5 checks passed

mohsen-ghafouri deleted the fix/hide-missing-keypair branch July 26, 2024 15:41

ilmotta pushed a commit that referenced this pull request Jul 28, 2024

[#20524] fix: the missed keypairs are shown in the key pair list scre…

b4e84f5

…en (#20888)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#20524] fix: the missed keypairs are shown in the key pair list screen #20888

[#20524] fix: the missed keypairs are shown in the key pair list screen #20888

mohsen-ghafouri commented Jul 25, 2024

status-im-auto commented Jul 25, 2024 •

edited

Loading

ajayesivan left a comment

smohamedjavid left a comment

status-im-auto commented Jul 25, 2024

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

status-im-auto commented Jul 25, 2024

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

mariia-skrypnyk commented Jul 26, 2024

[#20524] fix: the missed keypairs are shown in the key pair list screen #20888

[#20524] fix: the missed keypairs are shown in the key pair list screen #20888

Conversation

mohsen-ghafouri commented Jul 25, 2024

Summary

Areas that maybe impacted

Steps to test

Result

status-im-auto commented Jul 25, 2024 • edited Loading

Jenkins Builds

ajayesivan left a comment

Choose a reason for hiding this comment

smohamedjavid left a comment

Choose a reason for hiding this comment

status-im-auto commented Jul 25, 2024

71% of end-end tests have passed

Failed tests (1)

Class TestWalletMultipleDevice:

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (5)

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

status-im-auto commented Jul 25, 2024

86% of end-end tests have passed

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (6)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

mariia-skrypnyk commented Jul 26, 2024

status-im-auto commented Jul 25, 2024 •

edited

Loading