-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request compressed keys #10325
Milestone
Comments
This was referenced May 7, 2020
This was referenced Jun 18, 2020
The Awaiting on specs to be cleared for merge |
Thanks for making this happen! |
@hesterbruikman is this still relevant? |
Obsolete and will be re-considered in the redesigned app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is paired with and should follow implementation of status-im/status-go#1937
Problem
Chat key is currently shown (as used) as the public key in full. This is unnecessarily daunting. Compressing the public key used for chat can make it less daunting, more space efficient in the UI as well as reducing file size and visual complexity of the QR code.
Implementation
Status-go will include two new functions:
02 and 03 will be used for compressed keys, 04 will be maintained for decompressed keys
status-react should always receive the decompressed key (no changes to current implementation) unless the compressed key is requested. Instances where the compressed key should be requested include:
Onboarding
>Choose a chat name
Profile
>Header
Profile
>Share icon
>QR code popover
Invite friends
url fromInvite friends
button and+ -button
>Invite friends
Profile details
Profile details
>Share icon
>QR code popover
Future Steps
The text was updated successfully, but these errors were encountered: