Address commit comments (commit `3eff83f`)

[stdlib-bot]

This commit has 9 comment(s) from core contributors that require attention.

Commit: 3eff83f89e26a589f041538aa34fe47446cbdde8

Comments:

• 3eff83f#r152951260

  Line 191: @stdlib-bot This empty line should be removed.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/README.md

  Lines 188 to 194 in 3eff83f

  	Evaluates the [moment-generating function][mgf] (MGF) for a [Gumbel][gumbel-distribution] distribution with parameters `mu` (location parameter) and `beta > 0` (scale parameter).
  	```c
  	double out = stdlib_base_dists_gumbel_mgf( -1.0, 0.0, 1.0 );
  	// returns ~6.0

• 3eff83f#r152951330

  Line 193: @stdlib-bot This should be ( -1.0, 0.0, 3.0 ); to match the JS example above.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/README.md

  Lines 190 to 196 in 3eff83f

  	```c
  	double out = stdlib_base_dists_gumbel_mgf( -1.0, 0.0, 1.0 );
  	// returns ~6.0
  	```

• 3eff83f#r152951348

  Line 187: @stdlib-bot This should be mgf, not median.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/README.md

  Lines 184 to 190 in 3eff83f

  	#include "stdlib/stats/base/dists/gumbel/mgf.h"
  	```
  	#### stdlib_base_dists_gumbel_median( t, mu, beta )
  	Evaluates the [moment-generating function][mgf] (MGF) for a [Gumbel][gumbel-distribution] distribution with parameters `mu` (location parameter) and `beta > 0` (scale parameter).

• 3eff83f#r152951368

  Line 194: @stdlib-bot The JS example above has this as exact. We should probably follow suit here. s/~6.0/6.0/

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/README.md

  Lines 191 to 197 in 3eff83f

  	```c
  	double out = stdlib_base_dists_gumbel_mgf( -1.0, 0.0, 1.0 );
  	// returns ~6.0
  	```
  	The function accepts the following arguments:

• 3eff83f#r152951393

  Line 49: @stdlib-bot The additional parentheses are unnecessary and should be removed.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/benchmark/benchmark.js

  Lines 46 to 52 in 3eff83f

  	for ( i = 0; i < len; i++ ) {
  	mu[ i ] = uniform( -50.0, 50.0 );
  	beta[ i ] = uniform( EPS, 20.0 );
  	t[ i ] = uniform( 0.0, ( 1.0 / beta[ i ] ) );
  	}
  	b.tic();

• 3eff83f#r152951403

  Line 58: @stdlib-bot The parentheses around 1.0 / beta[ i ] are unnecessary and should be removed.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/benchmark/benchmark.native.js

  Lines 55 to 61 in 3eff83f

  	for ( i = 0; i < len; i++ ) {
  	mu[ i ] = uniform( -50.0, 50.0 );
  	beta[ i ] = uniform( EPS, 20.0 );
  	t[ i ] = uniform( 0.0, ( 1.0 / beta[ i ] ) );
  	}
  	b.tic();

• 3eff83f#r152951518

  Line 107: @stdlib-bot The order of the arguments should be reversed and s/0/0.0/

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/benchmark/c/benchmark.c

  Lines 104 to 110 in 3eff83f

  	for ( i = 0; i < 100; i++ ) {
  	mu[ i ] = random_uniform( -50.0, 50.0 );
  	beta[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 20.0 );
  	_t[ i ] = random_uniform( 1.0 / beta[ i ], 0 );
  	}
  	t = tic();

• 3eff83f#r152951549

  Line 22: @stdlib-bot L22-24 should be

  /*
  * If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler.
  */

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/include/stdlib/stats/base/dists/gumbel/mgf.h

  Lines 19 to 25 in 3eff83f

  	#ifndef STDLIB_STATS_BASE_DISTS_GUMBEL_MGF_H
  	#define STDLIB_STATS_BASE_DISTS_GUMBEL_MGF_H
  	/*
  	* Evaluates the moment-generating function (MGF) for a Gumbel distribution with location parameter `mu` and scale parameter `b` at a value `t`.
  	*/
  	#ifdef __cplusplus

• 3eff83f#r152951566

  Line 30: @stdlib-bot This description should be

  Evaluates the moment-generating function (MGF) for a Gumbel distribution with location parameter `mu` and scale parameter `b` at a value `t`.
  

  stdlib/lib/node_modules/@stdlib/stats/base/dists/gumbel/mgf/include/stdlib/stats/base/dists/gumbel/mgf.h

  Lines 27 to 33 in 3eff83f

  	#endif
  	/**
  	* Evaluates the cumulative distribution function (MGF) for a Gumbel distribution with location parameter `mu` and scale parameter `beta` at a value `x`.
  	*/
  	double stdlib_base_dists_gumbel_mgf( const double t, const double mu, const double beta );

Interested in helping improve the project? If you are, the comment linked to above has 9 comment(s) from core contributors that could use your attention.

What do you need to do?

1. Open the above linked comments mentioning @stdlib-bot.
2. Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
3. If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
4. Make all the desired changes and commit those changes to a local branch.
5. Push the changes to GitHub and open a new pull request against the develop branch of the main stdlib development repository.

Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.

And that's it!

Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌

---

Notes

• For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!

---

This issue was created automatically to address commit comments tagging @stdlib-bot.

[stdlib-bot]

👋 Important: PLEASE READ 👋

This issue has been labeled as a good first issue and is available for anyone to work on.

If this is your first time contributing to an open source project, some aspects of the development process may seem unusual, arcane, or some combination of both.

1. You cannot "claim" issues. People new to open source often want to "claim" or be assigned an issue before beginning work. The typical rationale is that people want to avoid wasted work in the event that someone else ends up working the issue. However, this practice is not effective in open source, as it often leads to "issue squatting", in which an individual asks to be assigned, is granted their request, and then never ends up working on the issue. Accordingly, you are encouraged to communicate your intent to address this issue, ideally by providing a rough outline as to how you plan to address the issue or asking clarifying questions, but, at the end of the day, we will take running code and rough consensus in order to move forward quickly.
2. We have a very high bar for contributions. We have very high standards for contributions and expect all contributions—whether new features, tests, or documentation—to be rigorous, thorough, and complete. Once a pull request is merged into stdlib, that contribution immediately becomes the collective responsibility of all maintainers of stdlib. When we merge code into stdlib, we are saying that we, the maintainers, commit to reviewing subsequent changes and making bugfixes to the code. Hence, in order to ensure future maintainability, this naturally leads to a higher standard of contribution.

Before working on this issue and opening a pull request, please read the project's contributing guidelines. These guidelines and the associated development guide provide important information, including links to stdlib's Code of Conduct, license policy, and steps for setting up your local development environment.

To reiterate, we strongly encourage you to refer to our contributing guides before beginning work on this issue. Failure to follow our guidelines significantly decreases the likelihood that you'll successfully contribute to stdlib and may result in automatic closure of a pull request without review.

Setting up your local development environment is a critical first step, as doing so ensures that automated development processes for linting, license verification, and unit testing can run prior to authoring commits and pushing changes. If you would prefer to avoid manual setup, we provide pre-configured development containers for use locally or in GitHub Codespaces.

We place a high value on consistency throughout the stdlib codebase. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.

• If you are attempting to contribute a new package, sometimes the best approach is to simply copy the contents of an existing package and then modify the minimum amount necessary to implement the feature (e.g., changing descriptions, parameter names, and implementation).
• If you are contributing tests, find a package implementing a similar feature and emulate the tests of that package.
• If you are updating documentation, examine several similar packages and emulate the content, style, and prose of those packages.

In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before beginning work on this issue.

✨ Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. ✨