-
-
Notifications
You must be signed in to change notification settings - Fork 867
Description
This commit has 5 comment(s) from core contributors that require attention.
Commit: 8fa382766ef9fac1355c9ad98cf3e81f47387016
Comments:
-
Line 174: @stdlib-bot This return value is incorrect. The example should be updated to use similar values as L61 and the return value should be updated accordingly.
stdlib/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md
Lines 171 to 177 in 8fa3827
```c double out = stdlib_base_dists_cauchy_cdf( 0.5, 0.0, 2.0 ); // returns ~0.333 ``` The function accepts the following arguments: -
Line 218: @stdlib-bot Variables should be ordered based on length.
stdlib/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md
Lines 215 to 221 in 8fa3827
int main( void ) { double gamma; double x; double x0; double y; int i; -
Line 35: @stdlib-bot This variable name is incorrect. It should be
cdf
and updated here and below.stdlib/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.native.js
Lines 32 to 38 in 8fa3827
// VARIABLES // var logcdf = tryRequire( resolve( __dirname, './../lib/native.js' ) ); var opts = { 'skip': ( logcdf instanceof Error ) }; -
Line 31: @stdlib-bot These variables should be ordered by length.
stdlib/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c
Lines 28 to 34 in 8fa3827
int main( void ) { double gamma; double x; double x0; double y; int i; -
Line 30: @stdlib-bot This description is incorrect and should be updated for a Cauchy distribution.
Lines 27 to 33 in 8fa3827
#endif /** * Evaluates the cumulative distribution function (CDF) for a Weibull distribution with shape parameter `k` and scale parameter `lambda` at a value `x`. */ double stdlib_base_dists_cauchy_cdf( const double x, const double x0, const double gamma );
Interested in helping improve the project? If you are, the comment linked to above has 5 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.