-
-
Notifications
You must be signed in to change notification settings - Fork 867
Description
This commit has 2 comment(s) from core contributors that require attention.
Commit: 0025233fc631a66f86f0139edd2ee9a37885193f
Comments:
-
Line 156: @stdlib-bot This example is incorrect.
p
should be a probability. This example and the return value should be updated to match the JS example above.stdlib/lib/node_modules/@stdlib/stats/base/dists/geometric/variance/README.md
Lines 153 to 159 in 0025233
Returns the [variance][variance] of a [geometric][geometric-distribution] distribution with success probability `p`. ```c double out = stdlib_base_dists_geometric_variance( 9.0 ); // returns 9.0 ``` -
Line 52: @stdlib-bot This should be updated to use
random/base/uniform
as done in benchmark.js.stdlib/lib/node_modules/@stdlib/stats/base/dists/geometric/variance/benchmark/benchmark.native.js
Lines 49 to 55 in 0025233
len = 100; p = new Float64Array( len ); for ( i = 0; i < len; i++ ) { p[ i ] = ( randu() * 1.0 ) + EPS; } b.tic();
Interested in helping improve the project? If you are, the comment linked to above has 2 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.