-
-
Notifications
You must be signed in to change notification settings - Fork 867
Description
This commit has 3 comment(s) from core contributors that require attention.
Commit: a74d773fe8fc148cc4bc7619e868624c2e499bc7
Comments:
-
Line 114: @stdlib-bot To match the conventions in the rest of the line, this should be
x[ i%100 ]
.stdlib/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/benchmark/c/benchmark.c
Lines 111 to 117 in a74d773
t = tic(); for ( i = 0; i < ITERATIONS; i++ ) { y = stdlib_base_dists_frechet_logcdf( x[i%100], alpha[ i%100 ], s[ i%100 ], m[ i%100 ] ); if ( y != y ) { printf( "should not return NaN\n" ); break; -
Line 205: @stdlib-bot This return value is incorrect. It should be
~-0.141
stdlib/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/README.md
Lines 202 to 208 in a74d773
```c double y = stdlib_base_frechet_logcdf( 10.0, 2.0, 3.0, 2.0 ); // returns ~0.141 ``` The function accepts the following arguments: -
Line 35: @stdlib-bot The return value should be
~-0.141
stdlib/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/src/main.c
Lines 32 to 38 in a74d773
* * @example * double y = stdlib_base_dists_frechet_logcdf( 10.0, 2.0, 3.0, 2.0 ); * // returns ~0.141 */ double stdlib_base_dists_frechet_logcdf( const double x, const double alpha, const double s, const double m ) { double z;
Interested in helping improve the project? If you are, the comment linked to above has 3 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.