Skip to content

feat: add C implementation for math/base/assert/is-negative-integer #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat: add C implementation for math/base/assert/is-negative-integer #1820

merged 2 commits into from
Mar 11, 2024

Conversation

kawaho2
Copy link
Contributor

@kawaho2 kawaho2 commented Mar 10, 2024

Resolves #1761 .

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for math/base/assert/is-negative-integer

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/assert/is-negative-integer feat: add C implementation for math/base/assert/is-negative-integer Mar 11, 2024
@Planeshifter
Update lib/node_modules/@stdlib/math/base/assert/is-negative-integer/…
e8eea16 
…manifest.json

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for your contribution!

@Planeshifter Planeshifter merged commit c66d855 into stdlib-js:develop Mar 11, 2024
@kawaho2 kawaho2 deleted the is-negative-integer branch March 11, 2024 06:15
This was referenced Mar 17, 2024
Closed
Closed
@kawaho2 kawaho2 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/assert/is-negative-integer
2 participants
@kawaho2 @Planeshifter