-
-
Notifications
You must be signed in to change notification settings - Fork 870
refactor: update blas/ext/base/scusumkbn
to follow current project conventions
#2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dear @kgryte @Pranavchiku and @Planeshifter. I've implemented the requested changes. Would you be able to take a moment to review them when you have some time? Your feedback would be greatly appreciated. Thank you kindly. |
blas/ext/base/scusumkbn
to follow current project conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; thank you for the edits! Will merge your PR shortly.
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/blas/ext/base/scusumkbn/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn/test/test.ndarray.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vr-varad Left some comments, which should be addressed before this PR can be merged.
Hello @kgryte, I've made the necessary adjustments. Could you please take a moment to review them? Your input would be greatly appreciated. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vr-varad This PR is close to ready. Some remaining changes are necessary for the manifest.json
file.
@kgryte Made the changes as suggested. |
@kgryte are there still tabs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this, @vr-varad.
@vr-varad Would you mind checking the box in the OP indicating that you've read the contributing guidelines? This needs to be checked in order to confirm that you agree to licensing terms and the Developer's Certificate of Origin. |
@kgryte done. |
Description
refactor: update blas/ext/base/scusumkbn to follow current project conventions
Related Issues
This pull request:
blas/ext/base/scusumkbn
to follow current project conventions #1517Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers