Skip to content

refactor: update blas/ext/base/scusumkbn to follow current project conventions #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 24, 2024
Merged

refactor: update blas/ext/base/scusumkbn to follow current project conventions #2012

merged 13 commits into from
Mar 24, 2024

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Mar 23, 2024

Description

refactor: update blas/ext/base/scusumkbn to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 23, 2024
@vr-varad
Copy link
Contributor Author

Dear @kgryte @Pranavchiku and @Planeshifter. I've implemented the requested changes. Would you be able to take a moment to review them when you have some time? Your feedback would be greatly appreciated. Thank you kindly.

@kgryte kgryte changed the title refactor: update blas/ext/base/scusumkbn to follow current project co… refactor: update blas/ext/base/scusumkbn to follow current project conventions Mar 23, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 23, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you for the edits! Will merge your PR shortly.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vr-varad Left some comments, which should be addressed before this PR can be merged.

@vr-varad
Copy link
Contributor Author

Hello @kgryte, I've made the necessary adjustments. Could you please take a moment to review them? Your input would be greatly appreciated. Thank you.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vr-varad This PR is close to ready. Some remaining changes are necessary for the manifest.json file.

@vr-varad
Copy link
Contributor Author

@kgryte Made the changes as suggested.

@vr-varad
Copy link
Contributor Author

@kgryte are there still tabs?

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @vr-varad.

@kgryte
Copy link
Member

kgryte commented Mar 24, 2024

@vr-varad Would you mind checking the box in the OP indicating that you've read the contributing guidelines? This needs to be checked in order to confirm that you agree to licensing terms and the Developer's Certificate of Origin.

@vr-varad
Copy link
Contributor Author

@kgryte done.

@kgryte kgryte merged commit 9b2ca2c into stdlib-js:develop Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/scusumkbn to follow current project conventions
4 participants