Skip to content

feat: add blas/base/zaxpy #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 9, 2024
Merged

feat: add blas/base/zaxpy #2468

merged 13 commits into from
Jul 9, 2024

Conversation

aman-095
Copy link
Member

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to scale values of input complex double-precision floating-point vector by another complex double-precision floating-point constant and add the result to another complex double-precision floating-point vector as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/zaxpy is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jun 27, 2024
@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Jul 6, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Jul 9, 2024
@kgryte
Copy link
Member

kgryte commented Jul 9, 2024

@aman-095 Do you want to add the C/Fortran implementation to this package in this PR or would you prefer to get this merged and add the implementations in a separate PR?

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far. Had to make a variety of clean-up changes, but I think we should be good in terms of the JS implementation.

@kgryte
Copy link
Member

kgryte commented Jul 9, 2024

As discussed offline, this PR is good to merge. The Fortran implementation requires being able to link to Fortran deps, which we still need to sort out. Thanks, @aman-095!

@kgryte kgryte merged commit 85ffc1a into stdlib-js:develop Jul 9, 2024
8 checks passed
@aman-095 aman-095 mentioned this pull request Jul 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants