Skip to content

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • Adds tests to ndarray/base/map for 100% coverage.

Related Issues

Does this pull request have any related issues?

This pull request:

  • none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@headlessNode
Copy link
Member Author

@kgryte Please review, thanks!

@kgryte kgryte added Needs Review A pull request which needs code review. Tests Pull requests specifically adding tests. labels Sep 7, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 8, 2024
@kgryte
Copy link
Member

kgryte commented Sep 8, 2024

Re: failing benchmark workflow. This is due to a timeout. I ran the benchmarks locally and all ran successfully. As such, I'll ignore the workflow failure and go ahead and merge...

@kgryte kgryte merged commit 5debe82 into stdlib-js:develop Sep 8, 2024
9 of 10 checks passed
@headlessNode headlessNode deleted the ndarray-map-tests branch September 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Pull requests specifically adding tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants