Skip to content

refactor: blas/ext/base/dsnansumpw #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2024
Merged

refactor: blas/ext/base/dsnansumpw #2855

merged 5 commits into from
Sep 2, 2024

Conversation

yaswanthkosuru
Copy link
Contributor

Resolves #1494.

Description

Refactor the existing code .

This pull request:

This pull request:

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines.
  • I have read and understood the
    [Code of Conduct](https://github.com/stdlib js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 2, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 2, 2024
@Planeshifter
chore: set options field in manifest.json
37d47d5 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
chore: update manifest.json
2979ff5 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Making some minor adjustments and will then merge it shortly.

@Planeshifter
chore: revert copyright year changes for existing files
cbb05b7 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
docs: fix argument in example code
a71454a 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Sep 2, 2024
@Planeshifter Planeshifter merged commit e9f4e07 into stdlib-js:develop Sep 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dsnansumpw to follow current project conventions
3 participants
@yaswanthkosuru @Planeshifter @stdlib-bot