Skip to content

refactor: use max-safe-nth-factorial package in math/base/special/falling-factorial #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2024
Merged

refactor: use max-safe-nth-factorial package in math/base/special/falling-factorial #2970

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a66f44
refactor: use constant package for max-factorial
gunjjoshi Sep 30, 2024
f5823ea
refactor: use constant package for max-factorial
gunjjoshi Sep 30, 2024
1a1c5be
docs: add eslint comments
gunjjoshi Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions lib/node_modules/@stdlib/math/base/special/falling-factorial/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ var floor = require( '@stdlib/math/base/special/floor' );
var abs = require( '@stdlib/math/base/special/abs' );
var FLOAT64_MAX = require( '@stdlib/constants/float64/max' );
var PINF = require( '@stdlib/constants/float64/pinf' );


// VARIABLES //

var MAX_FACTORIAL = 170; // TODO: consider packaging as constant
var FLOAT64_MAX_SAFE_NTH_FACTORIAL = require( '@stdlib/constants/float64/max-safe-nth-factorial' ); // eslint-disable-line id-length


// FUNCTIONS //
Expand Down Expand Up @@ -181,10 +177,10 @@ function fallingFactorial( x, n ) {
}
if ( x < 0.5 ) {
// Computing `1 + x` will throw away digits, so split up calculation...
if ( n > MAX_FACTORIAL-2 ) {
if ( n > FLOAT64_MAX_SAFE_NTH_FACTORIAL-2 ) {
// Given a ratio of two very large numbers, we need to split the calculation up into two blocks:
t1 = x * fallingFactorial( x-1.0, MAX_FACTORIAL-2 );
t2 = fallingFactorial( x-MAX_FACTORIAL+1.0, n-MAX_FACTORIAL+1 );
t1 = x * fallingFactorial( x-1.0, FLOAT64_MAX_SAFE_NTH_FACTORIAL-2 ); // eslint-disable-line max-len
t2 = fallingFactorial( x-FLOAT64_MAX_SAFE_NTH_FACTORIAL+1.0, n-FLOAT64_MAX_SAFE_NTH_FACTORIAL+1 ); // eslint-disable-line max-len
if ( FLOAT64_MAX/abs(t1) < abs(t2) ) {
return PINF;
}
Expand Down
Loading