Skip to content

feat: add C ndarray API and refactor blas/ext/base/dnannsumors #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 11, 2024
Merged

feat: add C ndarray API and refactor blas/ext/base/dnannsumors #2991

merged 14 commits into from
Nov 11, 2024

Conversation

headlessNode
Copy link
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnannsumors

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 7, 2024
headlessNode
headlessNode commented Oct 9, 2024
View reviewed changes
headlessNode
headlessNode commented Oct 11, 2024
View reviewed changes
headlessNode
headlessNode commented Oct 11, 2024
View reviewed changes
@headlessNode
Copy link
Member Author

@kgryte same CI failure after merge. It was not present before.

headlessNode
headlessNode commented Oct 11, 2024
View reviewed changes
headlessNode
headlessNode commented Oct 11, 2024
View reviewed changes
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. C Issue involves or relates to C. labels Oct 19, 2024
headlessNode
headlessNode commented Oct 20, 2024
View reviewed changes
headlessNode
headlessNode commented Oct 20, 2024
View reviewed changes
Planeshifter
Planeshifter approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Nov 11, 2024
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 11, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/dnannsumors`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2991

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit af8d471 into stdlib-js:develop Nov 11, 2024
17 of 18 checks passed
@headlessNode headlessNode deleted the dnannsumors-refactor branch November 11, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@headlessNode @stdlib-bot @Planeshifter @kgryte