-
-
Notifications
You must be signed in to change notification settings - Fork 867
feat: add every
method to array/fixed-endian-factory
#3200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
kindly give this a review @kgryte! |
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.every.length.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.every.length.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.every.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from reordering declared methods, this PR is looking good.
I've changed the position of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @aayush0325!
PR-URL: stdlib-js#3200 Closes: stdlib-js#3138 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#3200 Closes: stdlib-js#3138 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#3200 Closes: stdlib-js#3138 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>
Resolves #3138
Description
This pull request:
every
method toarray/fixed-endian-factory
with required docs, tests and benchmarksRelated Issues
This pull request:
every
method toarray/fixed-endian-factory
#3138Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers