Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #3152

Description

What is the purpose of this pull request?

This pull request:

  • adds reduceRight method to array/fixed-endian-factory
  • adds relevant tests and benchmarks
  • updates README.md with appropriate documentation

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 30, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1053/1312$
$\color{green}+80.26\%$
$\color{red}120/130$
$\color{green}+92.31\%$
$\color{red}19/30$
$\color{green}+63.33\%$
$\color{red}1053/1312$
$\color{green}+80.26\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

good evening, kindly give this a review @kgryte !

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aayush0325! PR is looking good.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 1, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 1, 2024

PR Commit Message

feat: add `reduceRight` method to `array/fixed-endian-factory`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3300
Closes: https://github.com/stdlib-js/stdlib/issues/3152

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 41af546 into stdlib-js:develop Dec 1, 2024
11 checks passed
@aayush0325 aayush0325 deleted the reduce-right branch February 16, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add reduceRight method to array/fixed-endian-factory
3 participants