Skip to content

feat: add constants/float64/max-safe-nth-tribonacci #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2024
Merged

feat: add constants/float64/max-safe-nth-tribonacci #3317

merged 5 commits into from
Dec 3, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Dec 2, 2024 •
edited by kgryte
Loading

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 2, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
constants/float64/max-safe-nth-tribonacci $\color{green}49/49$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}49/49$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 3, 2024
kgryte
kgryte requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from two small nitpicks, this LGTM.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 3, 2024
@gunjjoshi
docs: move variable declarations closer to the loop
720b9f4 
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@gunjjoshi
docs: move variable declarations closer to the loop
d4328e7 
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@kgryte
Apply suggestions from code review
09a80dc 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 3, 2024
@kgryte kgryte merged commit 27e0f3c into stdlib-js:develop Dec 3, 2024
11 checks passed
@kgryte kgryte changed the title feat: add constants/float32/max-safe-nth-tribonacci feat: add constants/float64/max-safe-nth-tribonacci Dec 3, 2024
jangnathan pushed a commit to jangnathan/stdlib that referenced this pull request Dec 7, 2024
@gunjjoshi @kgryte @jangnathan
feat: add constants/float64/max-safe-nth-tribonacci
3bfc9e2 
PR-URL: stdlib-js#3317
Ref: https://github.com/stdlib-js/stdlib/blob/299517a7a1e3494b93b2368c4f135a5826f88090/lib/node_modules/%40stdlib/math/base/special/tribonacci/src/main.c#L21
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @stdlib-bot @kgryte