Skip to content

Conversation

Vinit-Pandit
Copy link
Contributor

Resolves #3402 .

Description

What is the purpose of this pull request?

This pull request:

  • add implementation of stats/base/dists/arcsin/pdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@Vinit-Pandit Vinit-Pandit marked this pull request as draft December 11, 2024 08:19
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/pdf $\color{green}290/290$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}290/290$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit
Copy link
Contributor Author

Vinit-Pandit commented Dec 11, 2024

Have to add the benchmark.native.js and redme content for C implementation is pending

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 14, 2024
@Vinit-Pandit Vinit-Pandit marked this pull request as ready for review December 14, 2024 16:02
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 14, 2024
@Planeshifter Planeshifter changed the title feat: add implementation of stats/base/dists/arcsin/pdf feat: add implementation of stats/base/dists/arcsine/pdf Dec 15, 2024
@Planeshifter Planeshifter self-requested a review December 15, 2024 03:22
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently missing a benchmark.native.js file. Would you please add that one?

Otherwise, PR looks great and should be ready to land. Thanks for working on it @MeastroZI!

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MeastroZI!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 15, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 15, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add implementation of `stats/base/dists/arcsine/pdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3455
Closes: https://github.com/stdlib-js/stdlib/issues/3402

Co-authored-by: Vinit Pandit <vinitsharma2480@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit fbbdff6 into stdlib-js:develop Dec 15, 2024
21 checks passed
@Vinit-Pandit Vinit-Pandit deleted the pdfc branch December 20, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/mean
3 participants