Skip to content

feat: add c implementation of stats/base/dists/rayleigh/cdf #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

Vinit-Pandit
Copy link
Contributor

@Vinit-Pandit Vinit-Pandit commented Dec 15, 2024

Resolves #3798 .

Description

What is the purpose of this pull request?

This pull request:

  • add c implementation of stats/base/dists/rayleigh/cdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 15, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 15, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/rayleigh/cdf $\color{green}288/288$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}288/288$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit Vinit-Pandit changed the title feart: add c implementation of stats/base/dists/rayleigh/cdf feat: add c implementation of stats/base/dists/rayleigh/cdf Dec 15, 2024
…clude/stdlib/stats/base/dists/rayleigh/cdf.h

Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Left a bunch of comments that should be addressed, but otherwise this PR is looking good.

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your edits! Will merge once CI has passed.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 16, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 16, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024

PR Commit Message

feat: add c implementation of `stats/base/dists/rayleigh/cdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3931
Closes: https://github.com/stdlib-js/stdlib/issues/3798

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit d7f5b56 into stdlib-js:develop Dec 16, 2024
20 checks passed
@Vinit-Pandit Vinit-Pandit deleted the rayleigh/cdf branch December 20, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/rayleigh/cdf
3 participants