Skip to content

Conversation

AadishJ
Copy link
Contributor

@AadishJ AadishJ commented Dec 16, 2024

Resolves #3873.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the t logpdf.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the t logpdf in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/t/logpdf $\color{green}273/273$
$\color{green}+100.00\%$
$\color{green}17/17$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}273/273$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AadishJ! Fixed a few things but this should be ready to land otherwise.

@kgryte kgryte added the Ready To Merge A pull request which is ready to be merged. label Dec 16, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 16, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/t/logpdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3934
Closes: https://github.com/stdlib-js/stdlib/issues/3873

Co-authored-by: Aadish Jain <firestorm@AadishJain>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit ad7c388 into stdlib-js:develop Dec 16, 2024
20 checks passed
sethdivyansh pushed a commit to sethdivyansh/stdlib that referenced this pull request Dec 16, 2024
PR-URL: stdlib-js#3934
Closes: stdlib-js#3873

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/t/logpdf
4 participants