Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3418

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/bernoulli/pmf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 16, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bernoulli/pmf $\color{green}297/297$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}297/297$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 16, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 16, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 17, 2024 04:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 17, 2024
@Planeshifter Planeshifter added bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. and removed bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. labels Dec 20, 2024
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. labels Dec 20, 2024
@Planeshifter Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Dec 20, 2024
@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 17, 2025 07:46
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 17, 2025 16:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 17, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments that should be addressed before this PR can land.

@Neerajpathak07
Copy link
Member Author

@Planeshifter Updated the changes here and elsewhere!!

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 5, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this PR finally in. Thanks, @Neerajpathak07!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/bernoulli/pmf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3974
Closes: https://github.com/stdlib-js/stdlib/issues/3418

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 5, 2025
@Planeshifter Planeshifter merged commit 54ea642 into stdlib-js:develop Apr 5, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/bernoulli/pmf

3 participants