Skip to content

refactor: update stats/base/dnanmean native addon from C++ to C #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

Neerajpathak07
Copy link
Member

@Neerajpathak07 Neerajpathak07 commented Dec 20, 2024

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • updates the native addon from C++ to C

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 20, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmean $\color{green}359/359$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}359/359$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 20, 2024 21:11
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 20, 2024
@kgryte kgryte changed the title refactor: update stats/base/dnanmean to follow latest project conventions refactor: update stats/base/dnanmean native addon from C++ to C Dec 21, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 21, 2024
@Neerajpathak07
Copy link
Member Author

@kgryte made the essential changes!!

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 25, 2024
@kgryte kgryte merged commit 53da41e into stdlib-js:develop Dec 25, 2024
12 checks passed
@Neerajpathak07 Neerajpathak07 deleted the refactor-dnanmean branch December 26, 2024 14:03
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4112
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants