Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dnanmeanpn
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks in manifest.json

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 26, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 26, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmeanpn $\color{green}399/399$
$\color{green}+100.00\%$
$\color{green}26/26$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}399/399$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 26, 2024 08:25
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 26, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 18, 2025 12:55
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 18, 2025 13:10
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft February 1, 2025 13:09
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 1, 2025 13:34
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Feb 3, 2025

@kgryte
Can I get an idea that what the error in Lint against EditorConfig is about?

Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't spot any errors, thank you!

@aayush0325 aayush0325 removed the Needs Changes Pull request which needs changes before being merged. label Feb 9, 2025
@aayush0325 aayush0325 requested a review from kgryte February 9, 2025 09:22
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 9, 2025
@aayush0325 aayush0325 added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Feb 13, 2025
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Feb 14, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C `ndarray` interface and refactor implementation for `stats/base/dnanmeanpn`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4250

Co-authored-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Co-authored-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Co-authored-by: Neerajpathak07 <neerajrpathak710@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6ea60b4 into stdlib-js:develop Feb 14, 2025
45 checks passed
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
…s/base/dnanmeanpn`

PR-URL: stdlib-js#4250

Co-authored-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants