Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dsmeanwd #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 18, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dsmeanwd #4339

merged 9 commits into from
Jan 18, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsmeanwd
  • refactors JavaScript implementation
  • refactors tests, docs, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 29, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 29, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsmeanwd $\color{green}395/395$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}395/395$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 29, 2024 09:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 29, 2024
@Neerajpathak07
Copy link
Member Author

@Planeshifter I have created a few PR's would really appreciate a review cheers!

kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several comments. This PR needs clean-up before it can move forward.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 31, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 31, 2024
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 31, 2024
@Neerajpathak07
Copy link
Member Author

@kgryte I have made the essential changes to all the PR's related to the similar packages. Do let me know for changes is any!

@kgryte
Copy link
Member

kgryte commented Jan 18, 2025

@aayush0325 Would you mind taking a look at this PR?

aayush0325
aayush0325 requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, only a few minor comments. thanks!!

@Neerajpathak07
Copy link
Member Author

@aayush0325
I have addressed the changes I'll try and make the necessary changes to other PR's related to this as well.

@Neerajpathak07
Copy link
Member Author

Throws this error for some PR's :-
image
so for those I have kept it 2025

@Neerajpathak07
Copy link
Member Author

Made the necessary changes through out other PR's as well!

@aayush0325
Copy link
Member

Throws this error for some PR's :- image so for those I have kept it 2025

yes that's okay!

aayush0325
aayush0325 requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some very minor comments, once resolved this will be good to go

kgryte
kgryte approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. and removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jan 18, 2025
@kgryte kgryte merged commit 79e28d9 into stdlib-js:develop Jan 18, 2025
45 checks passed
@Neerajpathak07 Neerajpathak07 deleted the ndarray-dsmeanwd branch January 19, 2025 05:06
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
@Neerajpathak07 @saurabhraghuvanshii
feat: add C ndarray interface and refactor implementation for `stat…
5d17001 
…s/base/dsmeanwd`

PR-URL: stdlib-js#4339
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Neerajpathak07 added a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stat…
14ecfd6 
…s/base/dsmeanwd`

PR-URL: stdlib-js#4339
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@Neerajpathak07 @Vinit-Pandit
feat: add C ndarray interface and refactor implementation for `stat…
3b85500 
…s/base/dsmeanwd`

PR-URL: stdlib-js#4339
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Neerajpathak07 @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stat…
9ffca54 
…s/base/dsmeanwd`

PR-URL: stdlib-js#4339
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@aayush0325 aayush0325 Awaiting requested review from aayush0325

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neerajpathak07 @stdlib-bot @kgryte @aayush0325