feat: add C implementation for stats/base/dists/chi/logpdf
#4527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
Statistics
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>
Coverage Report
The above coverage report was generated for the changes in this PR. |
- Fixed header include order in addon.c - Removed cppcheck suppress directive - Updated benchmark to use uniform instead of randu - Fixed spacing in benchmark function call - Added return 0 in C example - Adjusted test tolerance for C implementation precision
Based on analysis of floating-point precision differences between JS and C implementations. The 40 EPS tolerance accounts for accumulated rounding errors in complex calculations involving ln and gammaln functions.
Explains why 40.0 EPS tolerance is needed due to accumulated floating-point precision differences in complex calculations involving ln and gammaln functions.
Changed printf format from 'logf(x;k)' to 'ln(f(x;k))' to match standard mathematical notation for natural logarithm of PDF.
- Changed printf format from 'logf(x;k)' to 'ln(f(x;k))' for consistency - Added missing 'return 0;' statement in C example
lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/examples/c/example.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
/stdlib merge |
stdlib-bot
added
bot: In Progress
|
/stdlib lint-autofix |
stdlib-bot
added
the
bot: In Progress
@Planeshifter, the slash command failed to complete. Please check the workflow logs for details. |
stdlib-bot
removed
the
bot: In Progress
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Jun 19, 2025
Planeshifter
added
the
Ready To Merge
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3492.
Description
This pull request:
Related Issues
This pull request:
@stdlib/stats/base/dists/chi/logpdf#3492Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers