Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dmeanlipw #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dmeanlipw #4733

merged 3 commits into from
Feb 14, 2025

Conversation

0PrashantYadav0
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dmeanlipw
  • refactors JavaScript implementation
  • updates tests, docs, examples and benchmarks

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 13, 2025
@0PrashantYadav0 0PrashantYadav0 marked this pull request as draft January 13, 2025 15:33
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 13, 2025
@0PrashantYadav0 0PrashantYadav0 changed the title refactor: add C ndarray interface and refactor implementation for stats/base/dmeanlipw feat: add C ndarray interface and refactor implementation for stats/base/dmeanlipw Jan 13, 2025
@0PrashantYadav0
feat: add C ndarray interface and refactor implementation
2b341ea 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@0PrashantYadav0 0PrashantYadav0 marked this pull request as ready for review January 13, 2025 15:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 13, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dmeanlipw $\color{green}359/359$
$\color{green}+100.00\%$ 		$\color{green}18/18$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}359/359$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0
chore: added comments
1487ac8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
aayush0325
aayush0325 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0PrashantYadav0
Copy link
Member Author

@kgryte Please review this pr. Thank you.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 14, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 14, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C ndarray interface and refactor implementation for `stats/base/dmeanlipw`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4733

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 954e7c1 into stdlib-js:develop Feb 14, 2025
29 checks passed
0PrashantYadav0 added a commit to 0PrashantYadav0/stdlib that referenced this pull request Feb 18, 2025
@0PrashantYadav0
feat: add C ndarray interface and refactor implementation for `stats/…
4b5c409 
…base/dmeanlipw`

PR-URL: stdlib-js#4733

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@0PrashantYadav0 @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stats/…
440e104 
…base/dmeanlipw`

PR-URL: stdlib-js#4733

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@aayush0325 aayush0325 aayush0325 approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0PrashantYadav0 @stdlib-bot @Planeshifter @aayush0325