-
-
Notifications
You must be signed in to change notification settings - Fork 870
bench: refactor random number generation in stats/base/dists/binomial
#4841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd use uniform instead of randu --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
Based on the above coverage report, I didn't make a major change in the stdlib/lib/node_modules/@stdlib/stats/base/dists/binomial/quantile/benchmark/benchmark.js Line 47 in 94e7cc0
|
No, the coverage report is not related to the benchmarks. Only the unit tests contribute to coverage data. For achieving 100% code coverage, that should be addressed in a separate PR. |
I can try to investigate into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR-URL: stdlib-js#4841 Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#4841 Reviewed-by: Athan Reines <kgryte@gmail.com>
Resolves none.
Description
This pull request:
stats/base/dists/binomial
.randu()
withuniform()
for cleaner and more consistent code.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers